-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HDFS-17500: Add missing operation name while authorizing some operations. #6776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ompleteFile operations
|
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch. After review #1829 again, it seems that still some other operations (such as fsync, recoverLease etc) do not be set. Please update them together. Another side, let's keep the same format as other operations: define operationName first then set it back to FSPermissionChecker.
|
💔 -1 overall
This message was automatically generated. |
…edBlockSize, recoverLease, getAdditionalDatanode, abandonBlock, fsync operations - in FSPermissionChecker
|
@jojochuang Can you please review? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. +1.
|
Committed to trunk. Thanks @kulkabhay for your contributions! |
…ons (apache#6776). Contributed by kulkabhay. Signed-off-by: He Xiaoqiao <[email protected]>
…ons (apache#6776). Contributed by kulkabhay. Signed-off-by: He Xiaoqiao <[email protected]>
…ons (apache#6776). Contributed by kulkabhay. Signed-off-by: He Xiaoqiao <[email protected]>
…some operations (apache#6776). Contributed by kulkabhay. Signed-off-by: He Xiaoqiao <[email protected]>
Description of PR
Currently, operation name is set to null in the FSPermissionChecker when authorizing 'create' and 'completeFile' operations. It may help the authorizer to optimize the authorization processing if the operation names are set correctly.
How was this patch tested?
Built hadoop-hdfs.jar with this patch, started the namenode configured with Ranger authorizer and verified that accesses to HDFS paths are authorized by Ranger policies correctly.
No new functionality is introduced in this patch, hence no changes to tests.