-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19216. (3.4) Upgrade Guice from 4.0 to 5.1.0 to support Java 17 #6930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
no need for me to review...it's already had the +1 vote if yetus is happy, merge it yourself. |
|
💔 -1 overall
This message was automatically generated. |
|
YARN-11047 pinned Guice 4.0 for HBase 1, seems we can not upgrade Guice on branch-3.4 since HADOOP-19107 was not landed on branch-3.4 |
|
Does this mean we need to pull forward the dropping of hbase 1 to branch-3.4? I'm personally OK with that, though it should be discussed on yarn-dev |
2b62ad2 to
223387e
Compare
steveloughran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's not merge until the hbase-2 only pr is in
|
💔 -1 overall
This message was automatically generated. |
…che#6913). Contributed by Cheng Pan. Signed-off-by: Ayush Saxena <[email protected]>
223387e to
309a803
Compare
|
💔 -1 overall
This message was automatically generated. |
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Backport 25e28b4 (#6913) from trunk to branch-3.4