- 
                Notifications
    You must be signed in to change notification settings 
- Fork 9.1k
HADOOP-19607. Remove workaround for protoc on M1 mac and unused property build.platform #7783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rty build.platform
| 💔 -1 overall 
 
 This message was automatically generated. | 
| @cnauroth Can you please review this PR? From my perspective, this seems reasonable. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the outdated workaround for protoc on Apple Silicon and drops the now-unused Maven property build.platform.
- Revert HADOOP-17939 by deleting the os.linuxandos.macbuild profiles.
- Remove the build.platformand fallbackos.detected.classifierproperties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, late LGTM. Thank you, @pan3793, @jojochuang and all.
Description of PR
This PR reverts HADOOP-17939 because protoc now has
osx-aarch_64artifacts available in Maven Central since v3.17.3https://repo1.maven.org/maven2/com/google/protobuf/protoc/3.17.3/
I also removed the Maven property
build.platform, which has been useless for a long time.How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?