HDDS-1461. Optimize listStatus api in OzoneFileSystem #782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
mukul1987
requested changes
May 7, 2019
There was a problem hiding this comment.
This is a great optimization.
Should this point to first character in the ASCII table ? Also lets verify that this for UTF-8 encoding as well.
There was a problem hiding this comment.
The first character in the ASCII table would not work in our case.
The second commit uses codec of RDBStore for handling the UTF-8 case.
|
💔 -1 overall
This message was automatically generated. |
xiaoyuyao
reviewed
May 15, 2019
There was a problem hiding this comment.
why do we move the acquireBucketLock inside the try block? The original pattern seems good to me.
xiaoyuyao
reviewed
May 15, 2019
There was a problem hiding this comment.
this needs to be moved out of try block.
xiaoyuyao
reviewed
May 15, 2019
mukul1987
requested changes
May 16, 2019
There was a problem hiding this comment.
keyName can be used here, as keyPath was derived from that.
There was a problem hiding this comment.
The comments here do not match with the assert in the next line. Can you please have a look.
There was a problem hiding this comment.
Please add a comment here to explain this line
|
@xiaoyuyao @mukul1987 I have made addresses the review comments in the latest commit. |
|
💔 -1 overall
This message was automatically generated. |
mukul1987
approved these changes
May 21, 2019
|
+1, the patch looks good to me. |
|
@mukul1987 @xiaoyuyao Thanks for reviewing the PR! I have merged it to trunk. |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
… method. Author: Boris S <[email protected]> Author: Boris S <[email protected]> Author: Boris Shkolnik <[email protected]> Reviewers: Bharath Kumarasubramanian <[email protected]> Closes apache#782 from sborya/removeExtendedSystemAdmin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in listStatus we make multiple getFileStatus calls. This can be optimized by converting to a single rpc call for listStatus.
Also currently listStatus has to traverse a directory recursively in order to list its immediate children. This happens because in OzoneManager all the metadata is stored in rocksdb sorted on keynames. The Jira also aims to fix this by using seek api provided by rocksdb.