HADOOP-19645. [ABFS][ReadAheadV2] Improve Metrics for Read Calls to identify type of read done. #7837

anujmodi2021 · 2025-07-30T05:11:12Z

Description of PR

JIRA: https://issues.apache.org/jira/browse/HADOOP-19645

There are a number of ways in which ABFS driver can trigger a network call to read data. We need a way to identify what type of read call was made from client. Plan is to add an indication for this in already present ClientRequestId header.

Following are types of read we want to identify:

Direct Read: Read from a given position in remote file. This will be synchronous read
Normal Read: Read from current seeked position where read ahead was bypassed. This will be synchronous read.
Prefetch Read: Read triggered from background threads filling up in memory cache. This will be asynchronous read.
Missed Cache Read: Read triggered after nothing was received from read ahead. This will be synchronous read.
Footer Read: Read triggered as part of footer read optimization. This will be synchronous.
Small File Read: Read triggered as a part of small file read. This will be synchronous read.

We will add another field in the Tracing Header (Client Request Id) for each request. We can call this field "Operation Specific Header" very similar to how we have "Retry Header" today. As part of this we will only use it for read operations keeping it empty for other operations. Moving ahead f we need to publish any operation specific info, same header can be used.

How was this patch tested?

New tests around changes in Tracing Header and intoduction of read specific header added.
Existing test suite ran across all combinations. Results added as comment

anujmodi2021 · 2025-07-30T11:15:43Z

:::: AGGREGATED TEST RESULT ::::

============================================================
HNS-OAuth-DFS

[WARNING] Tests run: 177, Failures: 0, Errors: 0, Skipped: 3
[WARNING] Tests run: 874, Failures: 0, Errors: 0, Skipped: 223
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 34
[WARNING] Tests run: 269, Failures: 0, Errors: 0, Skipped: 23

============================================================
HNS-SharedKey-DFS

[WARNING] Tests run: 177, Failures: 0, Errors: 0, Skipped: 4
[WARNING] Tests run: 874, Failures: 0, Errors: 0, Skipped: 172
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 34
[WARNING] Tests run: 269, Failures: 0, Errors: 0, Skipped: 10

============================================================
NonHNS-SharedKey-DFS

[WARNING] Tests run: 177, Failures: 0, Errors: 0, Skipped: 10
[WARNING] Tests run: 858, Failures: 0, Errors: 0, Skipped: 395
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 35
[WARNING] Tests run: 269, Failures: 0, Errors: 0, Skipped: 11

============================================================
AppendBlob-HNS-OAuth-DFS

[WARNING] Tests run: 177, Failures: 0, Errors: 0, Skipped: 3
[WARNING] Tests run: 874, Failures: 0, Errors: 0, Skipped: 234
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 58
[WARNING] Tests run: 269, Failures: 0, Errors: 0, Skipped: 23

============================================================
NonHNS-SharedKey-Blob

[WARNING] Tests run: 177, Failures: 0, Errors: 0, Skipped: 10
[WARNING] Tests run: 858, Failures: 0, Errors: 0, Skipped: 285
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 29
[WARNING] Tests run: 269, Failures: 0, Errors: 0, Skipped: 11

============================================================
NonHNS-OAuth-DFS

[WARNING] Tests run: 177, Failures: 0, Errors: 0, Skipped: 10
[WARNING] Tests run: 858, Failures: 0, Errors: 0, Skipped: 400
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 35
[WARNING] Tests run: 269, Failures: 0, Errors: 0, Skipped: 24

============================================================
NonHNS-OAuth-Blob

[WARNING] Tests run: 177, Failures: 0, Errors: 0, Skipped: 10
[WARNING] Tests run: 858, Failures: 0, Errors: 0, Skipped: 301
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 29
[WARNING] Tests run: 269, Failures: 0, Errors: 0, Skipped: 24

============================================================
AppendBlob-NonHNS-OAuth-Blob

[WARNING] Tests run: 177, Failures: 0, Errors: 0, Skipped: 10
[WARNING] Tests run: 858, Failures: 0, Errors: 0, Skipped: 346
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 53
[WARNING] Tests run: 269, Failures: 0, Errors: 0, Skipped: 24

============================================================
HNS-Oauth-DFS-IngressBlob

[WARNING] Tests run: 177, Failures: 0, Errors: 0, Skipped: 3
[WARNING] Tests run: 874, Failures: 0, Errors: 0, Skipped: 356
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 34
[WARNING] Tests run: 269, Failures: 0, Errors: 0, Skipped: 23

============================================================
NonHNS-OAuth-DFS-IngressBlob

[WARNING] Tests run: 177, Failures: 0, Errors: 0, Skipped: 10
[WARNING] Tests run: 858, Failures: 0, Errors: 0, Skipped: 397
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 35
[WARNING] Tests run: 269, Failures: 0, Errors: 0, Skipped: 24

Copilot

Pull Request Overview

This PR adds metrics to identify different types of read operations in the ABFS driver by enhancing the tracing header with operation-specific information. The main goal is to differentiate between various read types (direct, normal, prefetch, cache miss, footer, and small file reads) through the ClientRequestId header.

Key changes include:

Adding a ReadType enum to categorize different read operations
Updating the tracing header format to include versioning and operation-specific headers
Modifying read operations throughout the codebase to set appropriate ReadType values

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
ReadType.java	New enum defining six read operation types with abbreviated string representations
AbfsHttpConstants.java	Added TracingHeaderVersion enum for header versioning
TracingContext.java	Enhanced header construction with versioning and operation-specific headers
Listener.java	Added interface method for updating ReadType
AbfsInputStream.java	Updated read operations to set appropriate ReadType values
ReadBufferWorker.java	Added imports for ReadType and TracingContext
TracingHeaderValidator.java	Updated validation logic for new header format
TestApacheHttpClientFallback.java	Fixed test assertions for new header structure
TestTracingContext.java	Updated header parsing for new format

hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/TracingContext.java

...s/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/utils/TracingHeaderValidator.java

bhattmanish98 · 2025-07-31T13:48:07Z

...ls/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/AbfsHttpConstants.java

  public static final String STAR = "*";
  public static final String COMMA = ",";
  public static final String COLON = ":";
+  public static final String HYPHEN = "-";


We already have CHAR_HYPHEN defined for this.

bhattmanish98 · 2025-07-31T13:51:39Z

hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/TracingContext.java

    return String.format("%s_%s", header, previousFailure);
  }

+  private String getRetryHeader(final String previousFailure, String retryPolicyAbbreviation) {


Please add javadoc to all newly added methods

bhattmanish98 · 2025-07-31T13:58:02Z

...ols/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/TracingHeaderVersion.java

+  }
+
+  public int getFieldCount() {
+    return V1.fieldCount;


Shouldn't it be just return this.fieldCount?

Fixed, Thanks for pointing out

bhattmanish98 · 2025-07-31T13:58:24Z

...ols/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/TracingHeaderVersion.java

+  }
+
+  public String getVersion() {
+    return V1.version;


Same as above, it should be return this.version?

bhattmanish98 · 2025-07-31T13:59:17Z

...s/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsInputStream.java

  }

+  @Test
+  public void testReadTypeInTracingContextHeader() throws Exception {


Java Doc missing

...tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java

manika137 · 2025-08-01T05:18:00Z

...tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java

    //  bCursor that means the user requested data has not been read.
    if (fCursor < contentLength && bCursor > limit) {
      restorePointerState();
+      tracingContext.setReadType(ReadType.NORMAL_READ);


Before readOneBlock we're setting TC as normal read both here and line 439. In readOneBlock method- we're setting TC again to normal read- do we need it twice?
We can keep it once in the method only otherwise

Nice Catch, that seemed redundant, hence removed

manika137 · 2025-08-01T05:51:51Z

hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/TracingContext.java

+          + position + COLON
+          + operatedBlobCount + COLON
+          + httpOperation.getTracingContextSuffix() + COLON
+          + getOperationSpecificHeader(opType);


should we keep the op specific header before adding the HTTP client? It would get all req related info together and then network client.
Eg- .....:RE:1_EGR:NR:JDK

Sounds Better, Taken

manika137 · 2025-08-01T06:01:31Z

hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/TracingContext.java

    return String.format("%s_%s", header, previousFailure);
  }

+  private String getRetryHeader(final String previousFailure, String retryPolicyAbbreviation) {


we can remove the addFailureReasons method- it has no usage now

manika137 · 2025-08-01T06:24:30Z

...ols/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/TracingHeaderVersion.java

+public enum TracingHeaderVersion {
+
+  V0("", 8),
+  V1("v1", 13);


Since the next versions would be V1.1/V1.2- so should we consider starting with V1.0/V1.1?
And with the version updates- would we update the version field in V1 only or new V1.1 enum?

So every time we add a new header, we need to add a new version ?

We will have simple version strings like v0, v1, v2 and so on. This will help reduce char count in clientReqId.

With any new changes in the schema of Tracing Header (add/delete/rearrange) we need to bump up version and update the schema and getCurrentVersion method to return the latest version.

manika137 · 2025-08-01T08:38:51Z

...s/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsInputStream.java

+        .contains(readType.toString());
+  }
+
+//  private testReadTypeInTracingContextHeaderInternal(ReadType readType) throws Exception {


Nit- we can remove this

anmolanmol1234 · 2025-08-01T09:14:54Z

hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/TracingContext.java

  private String primaryRequestIdForRetry;
-
-  private Integer operatedBlobCount = null;
+  private Integer operatedBlobCount = 1; // Only relevant for rename-delete over blob endpoint where it will be explicitly set.


why is it changed from null to 1 ?

Because it was coming out as null in ClientReqId. Having a null value does not looks good and can be prone to NPE if someone used this value anywhere.
Since this is set only in rename/delete other ops are prone to NPE.

As to why set to 1, I thought for every operation this has to be 1. I am open to suggestions for a better default value but strongly feel null should be avoided.

Thoughts?

But there was a null check before it was added to the header which would avoid the NPE

Yes but we decided to keep the header schema fix and publishing this value as null does not look good in Client Request Id as it can be exposed to user.

anmolanmol1234 · 2025-08-01T09:27:00Z

...ols/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/TracingHeaderVersion.java

+  }
+
+  public static TracingHeaderVersion getCurrentVersion() {
+    return V1;


this needs to be updated everytime a new version is introduced, can it be dynamically fetched ?

We need to update it to the latest version every time we do a version upgrade.

anmolanmol1234 · 2025-08-01T09:29:17Z

hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/TracingContext.java

-      header += (":" + httpOperation.getTracingContextSuffix());
-      metricHeader += !(metricResults.trim().isEmpty()) ? metricResults  : "";
+    case ALL_ID_FORMAT:
+      header = TracingHeaderVersion.V1.getVersion() + COLON


should we use getCurrentVersion here ?

anmolanmol1234 · 2025-08-01T09:30:36Z

hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/TracingContext.java

+          + streamID + COLON
+          + opType + COLON
+          + getRetryHeader(previousFailure, retryPolicyAbbreviation) + COLON
+          + ingressHandler + COLON


these empty string checks are needed

With empty checks we cannot have a fixed schema. We need the proper defined schema where each position after split is fixed for all the headers and analysis can be done easily without worrying about the position of info we need to analyse.

anmolanmol1234 · 2025-08-01T09:35:01Z

hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/TracingContext.java

    case TWO_ID_FORMAT:
-      header = clientCorrelationID + ":" + clientRequestId;
-      metricHeader += !(metricResults.trim().isEmpty()) ? metricResults  : "";
+      header = TracingHeaderVersion.V1.getVersion() + COLON


same as above getCurrentVersion ?

anmolanmol1234 · 2025-08-01T09:41:12Z

hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/TestTracingContext.java

  private void checkHeaderForRetryPolicyAbbreviation(String header, String expectedFailureReason, String expectedRetryPolicyAbbreviation) {
-    String[] headerContents = header.split(":");
-    String previousReqContext = headerContents[6];
+    String[] headerContents = header.split(":", SPLIT_NO_LIMIT);


colon constant here as well since we are changing at other places

anmolanmol1234 · 2025-08-01T09:47:18Z

...s/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsInputStream.java

+    numOfReadCalls += 3; // 3 blocks of 1MB each.
+    doReturn(false).when(spiedConfig).isReadAheadV2Enabled();
+    doReturn(false).when(spiedConfig).isReadAheadEnabled();
+    testReadTypeInTracingContextHeaderInternal(spiedFs, fileSize, NORMAL_READ, numOfReadCalls);


should we also verify that it is normal_read for all the three calls made, currently it verifies for contains

anmolanmol1234 · 2025-08-01T09:47:42Z

...s/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsInputStream.java

+    numOfReadCalls += 3;
+    doReturn(true).when(spiedConfig).isReadAheadEnabled();
+    Mockito.doReturn(3).when(spiedConfig).getReadAheadQueueDepth();
+    testReadTypeInTracingContextHeaderInternal(spiedFs, fileSize, PREFETCH_READ, numOfReadCalls);


same here verify that 2 calls have prefetch_read

anmolanmol1234 · 2025-08-01T09:49:46Z

...s/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsInputStream.java

+    doReturn(true).when(spiedConfig).readSmallFilesCompletely();
+    doReturn(false).when(spiedConfig).optimizeFooterRead();
+    testReadTypeInTracingContextHeaderInternal(spiedFs, fileSize, SMALLFILE_READ, numOfReadCalls);
+  }


One test for direct read as well ?

violet-nspct · 2025-08-02T07:07:16Z

...tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java

        streamStatistics.remoteReadOperation();
      }
      LOG.trace("Trigger client.read for path={} position={} offset={} length={}", path, position, offset, length);
+      tracingContext.setPosition(String.valueOf(position));


Is there a test to verify position is correctly added to tracing context? Position is a key identifier for read operations.

Thanks for the suggestion. I updated the current test to assert on position as well.

anmolanmol1234 · 2025-08-04T09:10:28Z

...s/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsInputStream.java

+    if (readType == PREFETCH_READ) {
+      /*
+       * For Prefetch Enabled, first read can be Normal or Missed Cache Read.
+       * Sow e will assert only for last 2 calls which should be Prefetched Read.


nit typo: so

anmolanmol1234 · 2025-08-04T09:46:52Z

...s/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/utils/TracingHeaderValidator.java


  /**
-   * Sets the value of the number of blobs operated on
+   * Sets the value of the number of blobs operated on976345


anmolanmol1234 · 2025-08-04T09:47:42Z

...azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestApacheHttpClientFallback.java

            jdkCallsRegister[0]++;
            if (AbfsApacheHttpClient.usable()) {
-              Assertions.assertThat(tc.getHeader()).contains(JDK_IMPL);
+              Assertions.assertThat(tc.getHeader()).endsWith(JDK_IMPL);


this might fail if we add new header where the network library is not maintained as the last header, so contains looks better to me

anmolanmol1234 · 2025-08-04T09:51:57Z

...s/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsInputStream.java

+        verifyHeaderForReadTypeInTracingContextHeader(tracingContextList.get(i), readType, -1);
+      }
+    } else if (readType == DIRECT_READ) {
+      int expectedReadPos = ONE_MB/3;


comment for why are we starting with this position will help in clarity

Already added in comment above.

hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/TracingContext.java

bhattmanish98

+1 LGTM

hadoop-yetus · 2025-08-04T20:09:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 49s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 7 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	45m 11s		trunk passed
+1 💚	compile	0m 44s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 37s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	checkstyle	0m 34s		trunk passed
+1 💚	mvnsite	0m 42s		trunk passed
+1 💚	javadoc	0m 42s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 34s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	1m 9s		trunk passed
+1 💚	shadedclient	40m 38s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 30s		the patch passed
+1 💚	compile	0m 34s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 34s		the patch passed
+1 💚	compile	0m 29s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	javac	0m 29s		the patch passed
+1 💚	blanks	0m 1s		The patch has no blanks issues.
+1 💚	checkstyle	0m 20s		the patch passed
+1 💚	mvnsite	0m 33s		the patch passed
+1 💚	javadoc	0m 30s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 26s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	1m 8s		the patch passed
+1 💚	shadedclient	40m 51s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	2m 56s		hadoop-azure in the patch passed.
+1 💚	asflicense	0m 37s		The patch does not generate ASF License warnings.
		142m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7837/9/artifact/out/Dockerfile
GITHUB PR	#7837
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 3280cde505cb 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `c787d3b`
Default Java	Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7837/9/testReport/
Max. process+thread count	536 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7837/9/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

…dentify type of read done. (apache#7837) Contributed by Anuj Modi

Introducing Read Type Metric

ea1572a

github-actions bot added trunk TOOLS ABFS labels Jul 30, 2025

anujmodi2021 changed the title ~~Introducing Read Type Metric~~ HADOOP-19645. [ABFS][ReadAheadV2] Improve Metrics for Read Calls to identify type of read done. Jul 30, 2025

Tests

42ecdd0

anujmodi2021 marked this pull request as ready for review July 30, 2025 06:25

Fixed Failing Tests

224f712

This comment was marked as outdated.

Sign in to view

anujmodi2021 requested a review from Copilot July 31, 2025 04:09

Copilot AI reviewed Jul 31, 2025

View reviewed changes

anujmodi2021 added 2 commits July 30, 2025 22:50

Additional Tests

9a87ad5

Merge branch 'trunk' into HADOOP-19645

0d926b1

This comment was marked as outdated.

Sign in to view

Yetus Checks

9bb6cdb

bhattmanish98 reviewed Jul 31, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

manika137 reviewed Aug 1, 2025

View reviewed changes

...tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java Show resolved Hide resolved

manika137 reviewed Aug 1, 2025

View reviewed changes

anmolanmol1234 reviewed Aug 1, 2025

View reviewed changes

violet-nspct reviewed Aug 2, 2025

View reviewed changes

anujmodi2021 added 2 commits August 3, 2025 09:54

Addressing Comments

69ffec4

Test fix

132893f

This comment was marked as outdated.

Sign in to view

Comments

6345ec9

This comment was marked as outdated.

Sign in to view

anmolanmol1234 reviewed Aug 4, 2025

View reviewed changes

manika137 approved these changes Aug 4, 2025

View reviewed changes

anmolanmol1234 suggested changes Aug 4, 2025

View reviewed changes

bhattmanish98 reviewed Aug 4, 2025

View reviewed changes

hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/TracingContext.java Outdated Show resolved Hide resolved

Comments

9059784

bhattmanish98 approved these changes Aug 4, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

Comments Followup

c787d3b

anmolanmol1234 approved these changes Aug 5, 2025

View reviewed changes

anujmodi2021 merged commit 74bb044 into apache:trunk Aug 5, 2025
4 checks passed

anujmodi2021 added a commit to ABFSDriver/AbfsHadoop that referenced this pull request Aug 18, 2025

HADOOP-19645. [ABFS][ReadAheadV2] Improve Metrics for Read Calls to i…

5236d17

…dentify type of read done. (apache#7837) Contributed by Anuj Modi

HADOOP-19645. [ABFS][ReadAheadV2] Improve Metrics for Read Calls to identify type of read done. #7837

HADOOP-19645. [ABFS][ReadAheadV2] Improve Metrics for Read Calls to identify type of read done. #7837

Uh oh!

Conversation

anujmodi2021 commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

How was this patch tested?

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

anujmodi2021 commented Jul 30, 2025

============================================================ HNS-OAuth-DFS

============================================================ HNS-SharedKey-DFS

============================================================ NonHNS-SharedKey-DFS

============================================================ AppendBlob-HNS-OAuth-DFS

============================================================ NonHNS-SharedKey-Blob

============================================================ NonHNS-OAuth-DFS

============================================================ NonHNS-OAuth-Blob

============================================================ AppendBlob-NonHNS-OAuth-Blob

============================================================ HNS-Oauth-DFS-IngressBlob

============================================================ NonHNS-OAuth-DFS-IngressBlob

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

anujmodi2021 commented Jul 30, 2025 •

edited

Loading

============================================================
HNS-OAuth-DFS

============================================================
HNS-SharedKey-DFS

============================================================
NonHNS-SharedKey-DFS

============================================================
AppendBlob-HNS-OAuth-DFS

============================================================
NonHNS-SharedKey-Blob

============================================================
NonHNS-OAuth-DFS

============================================================
NonHNS-OAuth-Blob

============================================================
AppendBlob-NonHNS-OAuth-Blob

============================================================
HNS-Oauth-DFS-IngressBlob

============================================================
NonHNS-OAuth-DFS-IngressBlob

anmolanmol1234 Aug 1, 2025 •

edited

Loading