HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part10. #7841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
LGTM. |
slfan1989
approved these changes
Jul 31, 2025
|
🎊 +1 overall
This message was automatically generated. |
slfan1989
reviewed
Aug 1, 2025
|
|
||
| // Verify that the storages match before and after the test | ||
| Assert.assertArrayEquals(storageInfos, dnDescriptor.getStorageInfos()); | ||
| Assertions.assertArrayEquals(storageInfos, dnDescriptor.getStorageInfos()); |
There was a problem hiding this comment.
Assertions. It would be best if they could be extracted to imports.
slfan1989
reviewed
Aug 1, 2025
| } catch (Exception e) { | ||
| e.printStackTrace(); | ||
| Assert.fail("Failed to start BlockChecker: " + e); | ||
| Assertions.fail("Failed to start BlockChecker: " + e); |
There was a problem hiding this comment.
Assertions. It would be best if they could be extracted to imports.
slfan1989
reviewed
Aug 1, 2025
| InetSocketAddress nnAddr) throws IOException { | ||
| Assert.assertEquals(nnSocketAddr, nnAddr); | ||
| return namenode; | ||
| Assertions.assertEquals(nnSocketAddr, nnAddr); |
There was a problem hiding this comment.
Assertions. It would be best if they could be extracted to imports.
There was a problem hiding this comment.
Thanks a lot for your review—I'll update the code right away!
ozkoca
reviewed
Aug 1, 2025
| dnNewDataDirs.append(newVol.getAbsolutePath()); | ||
| } | ||
| try { | ||
| assertThat( |
There was a problem hiding this comment.
nit: You may consider using assertEquals
assertEquals(
dn.getConf().get(DFSConfigKeys.DFS_DATANODE_DATA_DIR_KEY),
dn.reconfigurePropertyImpl(
DFSConfigKeys.DFS_DATANODE_DATA_DIR_KEY,
dnNewDataDirs.toString()));
There was a problem hiding this comment.
Thanks for the suggestion—I'll update the code right away!
zhtttylz
force-pushed
the
hadoop-hdfs-part10
branch
from
dc2c458 to
f047a51
Compare
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
cnauroth
approved these changes
Aug 5, 2025
|
I committed this to trunk. Thank you @zhtttylz . Thank you @slfan1989 for reviewing. |
|
Thanks @cnauroth and @slfan1989 for reviewing and merging! |
75 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA:HDFS-12431. Upgrade JUnit from 4 to 5 in hadoop-hdfs Part10.
How was this patch tested?
Junit Test.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?