HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part12. #7873

zhtttylz · 2025-08-15T16:04:09Z

Description of PR

JIRA:HDFS-12431. Upgrade JUnit from 4 to 5 in hadoop-hdfs Part12.

How was this patch tested?

Junit Test.

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2025-08-15T21:44:39Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 37s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 48 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 45s		trunk passed
+1 💚	compile	1m 28s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	compile	1m 16s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	checkstyle	1m 19s		trunk passed
+1 💚	mvnsite	1m 23s		trunk passed
+1 💚	javadoc	1m 13s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 41s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	3m 24s		trunk passed
+1 💚	shadedclient	40m 59s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 10s		the patch passed
+1 💚	compile	1m 17s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javac	1m 17s		the patch passed
+1 💚	compile	1m 5s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	javac	1m 5s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 58s	/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs-project/hadoop-hdfs: The patch generated 90 new + 330 unchanged - 23 fixed = 420 total (was 353)
+1 💚	mvnsite	1m 12s		the patch passed
+1 💚	javadoc	0m 57s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 36s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	3m 11s		the patch passed
+1 💚	shadedclient	37m 25s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	195m 29s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 48s		The patch does not generate ASF License warnings.
		339m 1s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.TestCacheDirectivesWithViewDFS
	hadoop.hdfs.server.namenode.TestCacheDirectives
	hadoop.hdfs.server.namenode.TestNameNodeMXBean

Subsystem	Report/Notes
Docker	ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7873/1/artifact/out/Dockerfile
GITHUB PR	#7873
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux e586beab9caa 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `7936a4d`
Default Java	Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7873/1/testReport/
Max. process+thread count	5276 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7873/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2025-08-16T20:36:56Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 36s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 47 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	40m 27s		trunk passed
+1 💚	compile	1m 21s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	compile	1m 12s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	checkstyle	1m 9s		trunk passed
+1 💚	mvnsite	1m 17s		trunk passed
+1 💚	javadoc	1m 7s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 39s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	3m 57s		trunk passed
+1 💚	shadedclient	40m 49s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 10s		the patch passed
+1 💚	compile	1m 14s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javac	1m 14s		the patch passed
+1 💚	compile	0m 59s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	javac	0m 59s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 58s	/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs-project/hadoop-hdfs: The patch generated 79 new + 310 unchanged - 20 fixed = 389 total (was 330)
+1 💚	mvnsite	1m 11s		the patch passed
+1 💚	javadoc	0m 56s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 29s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	3m 8s		the patch passed
+1 💚	shadedclient	40m 42s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	159m 30s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 45s		The patch does not generate ASF License warnings.
		303m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7873/2/artifact/out/Dockerfile
GITHUB PR	#7873
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux f51f88f491d3 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `daca230`
Default Java	Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7873/2/testReport/
Max. process+thread count	3536 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7873/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2025-08-17T00:52:20Z

...src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAddOverReplicatedStripedBlocks.java

      set.set(index);
    }
-    Assert.assertFalse(set.get(groupSize - 1));
+    Assertions.assertFalse(set.get(groupSize - 1));


The best practice is to import it during the import.

slfan1989 · 2025-08-17T00:53:32Z

...t/java/org/apache/hadoop/hdfs/server/namenode/TestBlockPlacementPolicyRackFaultTolerant.java

      BlockPlacementStatus status = bm.getStriptedBlockPlacementPolicy()
              .verifyBlockPlacement(block.getLocations(), 5);
-      Assert.assertTrue(status.isPlacementPolicySatisfied());
+      Assertions.assertTrue(status.isPlacementPolicySatisfied());


It needs to be imported during the import, just like the above.

slfan1989 · 2025-08-17T00:54:27Z

...t/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDeduplicationMap.java

-    Assert.assertEquals(1, m.getId("1"));
-    Assert.assertEquals(2, m.getId("2"));
-    Assert.assertEquals(3, m.getId("3"));
+    Assertions.assertEquals(1, m.getId("1"));


just like the above.

Thanks for the feedback—I’ll make the updates right away!

slfan1989 · 2025-08-17T00:56:12Z

@zhtttylz Thanks for the contribution! Overall, it looks fine, but let’s fix the checkstyle issues.

hadoop-yetus · 2025-08-18T09:45:42Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	21m 53s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 47 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	45m 38s		trunk passed
+1 💚	compile	1m 26s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	compile	1m 12s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	checkstyle	1m 13s		trunk passed
+1 💚	mvnsite	1m 21s		trunk passed
+1 💚	javadoc	1m 15s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 43s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	3m 17s		trunk passed
+1 💚	shadedclient	43m 3s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 9s		the patch passed
+1 💚	compile	1m 19s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javac	1m 19s		the patch passed
+1 💚	compile	1m 5s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	javac	1m 5s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 1s		hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 310 unchanged - 20 fixed = 310 total (was 330)
+1 💚	mvnsite	1m 13s		the patch passed
+1 💚	javadoc	1m 3s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 32s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	3m 13s		the patch passed
+1 💚	shadedclient	42m 59s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	188m 52s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 50s		The patch does not generate ASF License warnings.
		364m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7873/3/artifact/out/Dockerfile
GITHUB PR	#7873
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux c094d34864ee 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `e2e3a25`
Default Java	Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7873/3/testReport/
Max. process+thread count	2231 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7873/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2025-08-19T00:36:26Z

@zhtttylz Thanks for the contribution! Merged into trunk.

zhtttylz · 2025-08-19T02:49:30Z

@slfan1989 Thanks for merging! I’ll submit the remaining changes shortly.

github-actions bot added HDFS trunk labels Aug 15, 2025

HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part12.

daca230

zhtttylz force-pushed the hadoop-hdfs-part12 branch from 7936a4d to daca230 Compare August 16, 2025 15:31

slfan1989 reviewed Aug 17, 2025

View reviewed changes

address review comments.

e2e3a25

slfan1989 approved these changes Aug 18, 2025

View reviewed changes

slfan1989 merged commit 818e3f0 into apache:trunk Aug 19, 2025
4 checks passed

slfan1989 mentioned this pull request Sep 14, 2025

[DISCUSS] [JDK17] Upgrade JUnit / JavaDoc from 4 to 5. #7337

Draft

75 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part12. #7873

HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part12. #7873

Uh oh!

zhtttylz commented Aug 15, 2025

Uh oh!

hadoop-yetus commented Aug 15, 2025

Uh oh!

hadoop-yetus commented Aug 16, 2025

Uh oh!

slfan1989 Aug 17, 2025

Uh oh!

slfan1989 Aug 17, 2025

Uh oh!

slfan1989 Aug 17, 2025

Uh oh!

zhtttylz Aug 17, 2025

Uh oh!

slfan1989 commented Aug 17, 2025

Uh oh!

hadoop-yetus commented Aug 18, 2025

Uh oh!

Uh oh!

slfan1989 commented Aug 19, 2025

Uh oh!

zhtttylz commented Aug 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part12. #7873

HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part12. #7873

Uh oh!

Conversation

zhtttylz commented Aug 15, 2025

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Aug 15, 2025

Uh oh!

hadoop-yetus commented Aug 16, 2025

Uh oh!

slfan1989 Aug 17, 2025

Choose a reason for hiding this comment

Uh oh!

slfan1989 Aug 17, 2025

Choose a reason for hiding this comment

Uh oh!

slfan1989 Aug 17, 2025

Choose a reason for hiding this comment

Uh oh!

zhtttylz Aug 17, 2025

Choose a reason for hiding this comment

Uh oh!

slfan1989 commented Aug 17, 2025

Uh oh!

hadoop-yetus commented Aug 18, 2025

Uh oh!

Uh oh!

slfan1989 commented Aug 19, 2025

Uh oh!

zhtttylz commented Aug 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants