HBASE-24153. Remove unnecessary super() in MultiVersionConcurrencyControl#MultiVer… #1468

leosunli · 2020-04-09T10:18:41Z

…sionConcurrencyControl()

Signed-off-by: sunlisheng [email protected]

…sionConcurrencyControl() Signed-off-by: sunlisheng <[email protected]>

Apache-HBase · 2020-04-09T11:02:00Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 43s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	7m 25s	master passed
+1 💚	checkstyle	1m 24s	master passed
+1 💚	spotbugs	2m 33s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	6m 16s	the patch passed
+1 💚	checkstyle	1m 26s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 6s	Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚	spotbugs	2m 36s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		41m 33s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1468
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux d3b0d7b4dee7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1fb693b`
Max. process+thread count	93 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-09T12:44:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 43s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 59s	master passed
+1 💚	compile	0m 57s	master passed
+1 💚	shadedjars	4m 54s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 12s	the patch passed
+1 💚	compile	0m 55s	the patch passed
+1 💚	javac	0m 55s	the patch passed
+1 💚	shadedjars	4m 41s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	117m 15s	hbase-server in the patch passed.
		143m 59s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1468
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4e620cf056fc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1fb693b`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/1/testReport/
Max. process+thread count	4514 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-09T13:45:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 11s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	7m 4s	master passed
+1 💚	compile	1m 8s	master passed
+1 💚	shadedjars	5m 43s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 41s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	6m 37s	the patch passed
+1 💚	compile	1m 8s	the patch passed
+1 💚	javac	1m 8s	the patch passed
+1 💚	shadedjars	5m 42s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 39s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	173m 0s	hbase-server in the patch passed.
		204m 43s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1468
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 52fd740bff7d 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1fb693b`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/1/testReport/
Max. process+thread count	3224 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-09T14:21:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	5m 37s	master passed
+1 💚	checkstyle	1m 8s	master passed
+1 💚	spotbugs	2m 0s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 56s	the patch passed
+1 💚	checkstyle	1m 5s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	10m 21s	Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚	spotbugs	2m 8s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		34m 39s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1468
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux c9911bd76155 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1fb693b`
Max. process+thread count	93 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani

+1

Apache-HBase · 2020-04-09T16:37:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	8m 55s	master passed
+1 💚	compile	1m 23s	master passed
+1 💚	shadedjars	7m 3s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 53s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	8m 5s	the patch passed
+1 💚	compile	1m 23s	the patch passed
+1 💚	javac	1m 23s	the patch passed
+1 💚	shadedjars	6m 28s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 47s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	132m 47s	hbase-server in the patch passed.
		170m 19s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1468
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 398e0425fb15 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1fb693b`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/2/testReport/
Max. process+thread count	3964 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-09T17:09:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 24s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	6m 0s	master passed
+1 💚	compile	0m 56s	master passed
+1 💚	shadedjars	4m 56s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 29s	the patch passed
+1 💚	compile	0m 58s	the patch passed
+1 💚	javac	0m 58s	the patch passed
+1 💚	shadedjars	4m 59s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	174m 23s	hbase-server in the patch passed.
		202m 15s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1468
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 49222b73a694 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1fb693b`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/2/testReport/
Max. process+thread count	2962 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

saintstack · 2020-04-10T05:11:13Z

Do you have a justification for changing this? It is just being explicit about the super call. Is it bad? Thanks.

leosunli · 2020-04-10T08:42:20Z

@saintstack
current code is no problem. But
this way of writing seem not to conform to the habit of java code.
Subclass constructor calls the default constructor of the parent class are implicit calls.
Thank you.

liuml07 · 2020-04-10T21:35:02Z

@saintstack Yes I agree with @leosunli super() will be implicitly added if not any super is called, I think it makes sense just to remove it here.

The parametrized constructor

public MultiVersionConcurrencyControl(long startPoint)

does not have super() and we know it's fine. Adding super() one place but not the other seems a bit inconsistent.

…MultiVersionConcurrencyControl() (#1468)" Forgot to add JIRA number. Reverting to add. This reverts commit 12a0c1d.

…nConcurrencyControl#MultiVersionConcurrencyControl() (#1468)"" A revert of a revert; i.e. a reapplication to add missing JIRA number This reverts commit c4026d1.

…MultiVersionConcurrencyControl() (apache#1468)" Forgot to add JIRA number. Reverting to add. This reverts commit 12a0c1d.

…nConcurrencyControl#MultiVersionConcurrencyControl() (apache#1468)"" A revert of a revert; i.e. a reapplication to add missing JIRA number This reverts commit c4026d1.

…MultiVersionConcurrencyControl() (apache#1468)" Forgot to add JIRA number. Reverting to add. This reverts commit 12a0c1d.

…nConcurrencyControl#MultiVersionConcurrencyControl() (apache#1468)"" A revert of a revert; i.e. a reapplication to add missing JIRA number This reverts commit c4026d1.

…sionConcurrencyControl() (apache#1468) Signed-off-by: sunlisheng <[email protected]> Signed-off-by: Mingliang Liu <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>

…MultiVersionConcurrencyControl() (apache#1468)" Forgot to add JIRA number. Reverting to add. This reverts commit 12a0c1d.

…nConcurrencyControl#MultiVersionConcurrencyControl() (apache#1468)"" A revert of a revert; i.e. a reapplication to add missing JIRA number This reverts commit c4026d1.

…sionConcurrencyControl() (apache#1468) Signed-off-by: sunlisheng <[email protected]> Signed-off-by: Mingliang Liu <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>

…MultiVersionConcurrencyControl() (apache#1468)" Forgot to add JIRA number. Reverting to add. This reverts commit 12a0c1d.

…nConcurrencyControl#MultiVersionConcurrencyControl() (apache#1468)"" A revert of a revert; i.e. a reapplication to add missing JIRA number This reverts commit c4026d1.

…sionConcurrencyControl() (apache#1468) Signed-off-by: sunlisheng <[email protected]> Signed-off-by: Mingliang Liu <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>

…MultiVersionConcurrencyControl() (apache#1468)" Forgot to add JIRA number. Reverting to add. This reverts commit 12a0c1d.

…nConcurrencyControl#MultiVersionConcurrencyControl() (apache#1468)"" A revert of a revert; i.e. a reapplication to add missing JIRA number This reverts commit c4026d1.

Remove unnecessary super() in MultiVersionConcurrencyControl#MultiVer…

7c287aa

…sionConcurrencyControl() Signed-off-by: sunlisheng <[email protected]>

leosunli force-pushed the HBASE-24153 branch from 2564a7e to 7c287aa Compare April 9, 2020 10:25

virajjasani approved these changes Apr 9, 2020

View reviewed changes

saintstack merged commit 12a0c1d into apache:master Apr 10, 2020

asfgit pushed a commit that referenced this pull request Apr 13, 2020

Revert "Remove unnecessary super() in MultiVersionConcurrencyControl#…

c4026d1

…MultiVersionConcurrencyControl() (#1468)" Forgot to add JIRA number. Reverting to add. This reverts commit 12a0c1d.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-24153. Remove unnecessary super() in MultiVersionConcurrencyControl#MultiVer… #1468

HBASE-24153. Remove unnecessary super() in MultiVersionConcurrencyControl#MultiVer… #1468

Uh oh!

leosunli commented Apr 9, 2020 •

edited

Loading

Uh oh!

Apache-HBase commented Apr 9, 2020

Uh oh!

Apache-HBase commented Apr 9, 2020

Uh oh!

Apache-HBase commented Apr 9, 2020

Uh oh!

Apache-HBase commented Apr 9, 2020

Uh oh!

virajjasani left a comment

Uh oh!

Apache-HBase commented Apr 9, 2020

Uh oh!

Apache-HBase commented Apr 9, 2020

Uh oh!

saintstack commented Apr 10, 2020

Uh oh!

leosunli commented Apr 10, 2020

Uh oh!

liuml07 commented Apr 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

HBASE-24153. Remove unnecessary super() in MultiVersionConcurrencyControl#MultiVer… #1468

HBASE-24153. Remove unnecessary super() in MultiVersionConcurrencyControl#MultiVer… #1468

Uh oh!

Conversation

leosunli commented Apr 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Apache-HBase commented Apr 9, 2020

Uh oh!

Apache-HBase commented Apr 9, 2020

Uh oh!

Apache-HBase commented Apr 9, 2020

Uh oh!

Apache-HBase commented Apr 9, 2020

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Apr 9, 2020

Uh oh!

Apache-HBase commented Apr 9, 2020

Uh oh!

saintstack commented Apr 10, 2020

Uh oh!

leosunli commented Apr 10, 2020

Uh oh!

liuml07 commented Apr 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

leosunli commented Apr 9, 2020 •

edited

Loading