Update TableMapReduceUtil.java #17
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TableMapReduceUtil is an utility class. I can't get it why these handy methods convertStringToScan and convertScanToString are package protected? We need to setup server side filters for mapreduce jobs so we must provide a scan object to TableInputFormat and we need those methods to put it into the job configuration. It just does not make sense.
Contributor
|
Could you please open an issue on our project tracker describing the issue and attach a patch: https://issues.apache.org/jira/browse/HBASE for more information on submitting contributions to the project, please read through our new contributor section: |
Contributor
|
This same change was made in HBASE-15223, and will be available in HBase 1.3.0+ and 2.0.0+ |
bbeaudreault
pushed a commit
that referenced
this pull request
Dec 15, 2022
bbeaudreault
pushed a commit
that referenced
this pull request
Dec 15, 2022
This reverts commit ed527a8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TableMapReduceUtil is an utility class. I can't get it why these handy methods convertStringToScan and convertScanToString are package protected?
We need to setup server side filters for mapreduce jobs so we must provide a scan object to TableInputFormat and we need those methods to put it into the job configuration. It just does not make sense.