HBASE-26027 The calling of HTable.batch blocked at AsyncRequestFuture… #3419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Impl.waitUntilDone caused by ArrayStoreException
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Jun 27, 2021
Contributor
Apache9
left a comment
Apache9
left a comment
There was a problem hiding this comment.
I'm not sure how could this change solve the problem described in the issue, but FWIW, I think we should honor operation timeout.
| public void waitUntilDone() throws InterruptedIOException { | ||
| try { | ||
| waitUntilDone(Long.MAX_VALUE); | ||
| long cutoff = (EnvironmentEdgeManager.currentTime() + this.operationTimeout) * 1000L; |
Contributor
There was a problem hiding this comment.
What if operationTimeout here is negative(which means no timeout), or Long.MAX_VALUE?
Contributor
Author
There was a problem hiding this comment.
What if operationTimeout here is negative(which means no timeout), or Long.MAX_VALUE?
Good point, exclude that cases seems better, will fix later, thanks.
Contributor
Author
There was a problem hiding this comment.
The type of operationTimeout is int, so seems no need to consider Long.MAX_VALUE case.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
approved these changes
Jun 30, 2021
bsglz
added a commit
that referenced
this pull request
Jul 1, 2021
#3419) * HBASE-26027 The calling of HTable.batch blocked at AsyncRequestFutureImpl.waitUntilDone caused by ArrayStoreException (cherry picked from commit 1d6eb77)
bsglz
added a commit
that referenced
this pull request
Jul 1, 2021
#3419) * HBASE-26027 The calling of HTable.batch blocked at AsyncRequestFutureImpl.waitUntilDone caused by ArrayStoreException (cherry picked from commit 1d6eb77)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Impl.waitUntilDone caused by ArrayStoreException