HBASE-22923 min version of RegionServer to move system table regions #3439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saintstack
reviewed
Jun 30, 2021
Contributor
saintstack
left a comment
saintstack
left a comment
There was a problem hiding this comment.
Nits that come of me trying to understand how this works. Thanks. Needs release noting of new config.
|
|
||
| /** | ||
| * When the operator uses this configuration option, any version between | ||
| * the current version and the new value of |
Contributor
There was a problem hiding this comment.
Is it 'new value' or just 'value'.
| /** | ||
| * When the operator uses this configuration option, any version between | ||
| * the current version and the new value of | ||
| * "hbase.min.version.move.system.tables" does not trigger any region movement. |
Contributor
There was a problem hiding this comment.
Do you want to explain what the 'region movement' is here? The auto-migration of system tables to newer server versions. A dev reading this w/o context might not tie the 'reigon movement' to the auto-movement to newer versions.
| * the current version and the new value of | ||
| * "hbase.min.version.move.system.tables" does not trigger any region movement. | ||
| * It is assumed that the configured range of versions do not require special | ||
| * handling of moving system table regions to higher versioned RegionServer. |
Contributor
There was a problem hiding this comment.
s/do/does/ and s/of//. Perhaps point at the location in the code where this is done.
Can we add examples of how this would work -- the ones from the JIRA?
| * Get a list of servers that this region cannot be assigned to. | ||
| * For system tables, we must assign them to a server with highest version. | ||
| */ | ||
| public List<ServerName> getExcludedServersForSystemTable() { |
Contributor
Author
There was a problem hiding this comment.
Yes, this is used by HMaster and AM both.
| } | ||
|
|
||
| /** | ||
| * Get a list of servers that this region can not assign to. |
Contributor
There was a problem hiding this comment.
There doesn't seem to be a 'region' passed to this method.... So is it any system table region?
| * "hbase.min.version.move.system.tables" if checkForMinVersion is true. | ||
| * | ||
| * @param checkForMinVersion if true, check for minVersionToMoveSysTables | ||
| * and decide moving system table regions accordingly. |
Contributor
There was a problem hiding this comment.
This method doesn't do move? It just looks for servers to exclude....
Contributor
Author
|
Sorry @saintstack for opening master branch PR later. Here is where other reviews took place: #3438 |
Contributor
|
My fault for not working on the PR where the action was. |
Contributor
Author
|
All nice comments, I agree, doc can be better. On it. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
Thank you for the review @saintstack. I have incorporated changes and merging based on sign-offs provided on other PR. Please let me know if you feel something still missing and will be happy to add addendum. |
virajjasani
added a commit
that referenced
this pull request
Jul 1, 2021
…3439) (#3438) Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Bharath Vissapragada <[email protected]>
virajjasani
added a commit
that referenced
this pull request
Jul 1, 2021
…3439) (#3438) Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Bharath Vissapragada <[email protected]>
virajjasani
added a commit
that referenced
this pull request
Jul 1, 2021
…3439) (#3438) Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Bharath Vissapragada <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.