Backport "HBASE-26616 Refactor code related to ZooKeeper authentication (#3973)" to branch-2.5

[ndimiduk]

This refactor reduces the size and scope of the ZKUtil class. The core of this refactor is
moving the login* methods from ZKUtil into their own class, ZKAuthentication. The class
JaasConfiguration is also moved along with them.

Signed-off-by: Andrew Purtell [email protected]
Signed-off-by: Duo Zhang [email protected]

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 37s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 44s	branch-2.5 passed
+1 💚	compile	3m 47s	branch-2.5 passed
+1 💚	checkstyle	1m 24s	branch-2.5 passed
+1 💚	spotbugs	2m 49s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 30s	the patch passed
+1 💚	compile	3m 45s	the patch passed
+1 💚	javac	0m 31s	hbase-zookeeper generated 0 new + 111 unchanged - 1 fixed = 111 total (was 112)
+1 💚	javac	3m 14s	hbase-server in the patch passed.
+1 💚	checkstyle	0m 14s	hbase-zookeeper: The patch generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4)
+1 💚	checkstyle	1m 6s	The patch passed checkstyle in hbase-server
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	18m 35s	Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.
+1 💚	spotbugs	3m 0s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 28s	The patch does not generate ASF License warnings.
		53m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4020/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4020
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 247329ab1091 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / 6a060ad
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 12500)
modules	C: hbase-zookeeper hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4020/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 8s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 37s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 56s	branch-2.5 passed
+1 💚	compile	1m 17s	branch-2.5 passed
+1 💚	shadedjars	6m 36s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 56s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 35s	the patch passed
+1 💚	compile	1m 17s	the patch passed
+1 💚	javac	1m 17s	the patch passed
+1 💚	shadedjars	6m 35s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 54s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 44s	hbase-zookeeper in the patch passed.
+1 💚	unit	146m 39s	hbase-server in the patch passed.
		177m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4020/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4020
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f674156bc7e3 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / 6a060ad
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4020/1/testReport/
Max. process+thread count	4130 (vs. ulimit of 12500)
modules	C: hbase-zookeeper hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4020/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	9m 8s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for branch
+1 💚	mvninstall	6m 15s	branch-2.5 passed
+1 💚	compile	1m 44s	branch-2.5 passed
+1 💚	shadedjars	8m 14s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 6s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 1s	the patch passed
+1 💚	compile	1m 38s	the patch passed
+1 💚	javac	1m 38s	the patch passed
+1 💚	shadedjars	8m 49s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 17s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 54s	hbase-zookeeper in the patch passed.
+1 💚	unit	206m 26s	hbase-server in the patch passed.
		253m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4020/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4020
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 79671f2dce5f 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / 6a060ad
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4020/1/testReport/
Max. process+thread count	2663 (vs. ulimit of 12500)
modules	C: hbase-zookeeper hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4020/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.