Skip to content

HBASE-22785 Fixed Checkstyle issues in exceptions and enhanced Javadoc #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2019
Merged

HBASE-22785 Fixed Checkstyle issues in exceptions and enhanced Javadoc #447

merged 1 commit into from
Aug 5, 2019

Conversation

@HorizonNet
Copy link
Contributor

@HorizonNet HorizonNet commented Aug 3, 2019

No description provided.

@Apache-HBase
Copy link

Apache-HBase commented Aug 3, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 195 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 338 master passed
+1 compile 23 master passed
+1 checkstyle 34 master passed
+1 shadedjars 293 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 21 master passed
0 spotbugs 70 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 67 master passed
_ Patch Compile Tests _
+1 mvninstall 322 the patch passed
+1 compile 24 the patch passed
+1 javac 24 the patch passed
+1 checkstyle 33 hbase-client: The patch generated 0 new + 0 unchanged - 15 fixed = 0 total (was 15)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 290 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1009 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 22 the patch passed
+1 findbugs 78 the patch passed
_ Other Tests _
+1 unit 101 hbase-client in the patch passed.
+1 asflicense 11 The patch does not generate ASF License warnings.
3283
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/1/artifact/out/Dockerfile
GITHUB PR #447
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 1fbcf8151a86 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-447/out/precommit/personality/provided.sh
git revision master / a6f0653
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/1/testReport/
Max. process+thread count 263 (vs. ulimit of 10000)
modules C: hbase-client U: hbase-client
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Aug 4, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 79 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 370 master passed
+1 compile 27 master passed
+1 checkstyle 30 master passed
+1 shadedjars 271 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 21 master passed
0 spotbugs 72 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 69 master passed
_ Patch Compile Tests _
+1 mvninstall 336 the patch passed
+1 compile 26 the patch passed
+1 javac 26 the patch passed
+1 checkstyle 31 hbase-client: The patch generated 0 new + 0 unchanged - 15 fixed = 0 total (was 15)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 262 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 976 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 20 the patch passed
+1 findbugs 76 the patch passed
_ Other Tests _
+1 unit 103 hbase-client in the patch passed.
+1 asflicense 10 The patch does not generate ASF License warnings.
3089
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/2/artifact/out/Dockerfile
GITHUB PR #447
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux f55c5faa3e8e 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-447/out/precommit/personality/provided.sh
git revision master / abb60fa
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/2/testReport/
Max. process+thread count 293 (vs. ulimit of 10000)
modules C: hbase-client U: hbase-client
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Aug 5, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 55 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 279 master passed
+1 compile 23 master passed
+1 checkstyle 30 master passed
+1 shadedjars 286 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 23 master passed
0 spotbugs 70 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 67 master passed
_ Patch Compile Tests _
+1 mvninstall 322 the patch passed
+1 compile 25 the patch passed
+1 javac 25 the patch passed
+1 checkstyle 29 hbase-client: The patch generated 0 new + 0 unchanged - 15 fixed = 0 total (was 15)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 262 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 919 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 23 the patch passed
+1 findbugs 75 the patch passed
_ Other Tests _
+1 unit 104 hbase-client in the patch passed.
+1 asflicense 11 The patch does not generate ASF License warnings.
2940
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/3/artifact/out/Dockerfile
GITHUB PR #447
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux b45d9685ca08 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-447/out/precommit/personality/provided.sh
git revision master / d0e5ea1
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/3/testReport/
Max. process+thread count 294 (vs. ulimit of 10000)
modules C: hbase-client U: hbase-client
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/3/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Aug 5, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 42 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
-1 mvninstall 140 root in master failed.
+1 compile 25 master passed
+1 checkstyle 31 master passed
+1 shadedjars 286 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 21 master passed
0 spotbugs 75 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 72 master passed
_ Patch Compile Tests _
-1 mvninstall 136 root in the patch failed.
+1 compile 22 the patch passed
+1 javac 22 the patch passed
+1 checkstyle 27 hbase-client: The patch generated 0 new + 0 unchanged - 15 fixed = 0 total (was 15)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 273 patch has no errors when building our shaded downstream artifacts.
-1 hadoopcheck 86 The patch causes 10 errors with Hadoop v2.8.5.
-1 hadoopcheck 173 The patch causes 10 errors with Hadoop v2.9.2.
-1 hadoopcheck 260 The patch causes 10 errors with Hadoop v3.1.2.
+1 javadoc 20 the patch passed
+1 findbugs 72 the patch passed
_ Other Tests _
+1 unit 103 hbase-client in the patch passed.
+1 asflicense 11 The patch does not generate ASF License warnings.
1605
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/4/artifact/out/Dockerfile
GITHUB PR #447
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux e18346ab4f23 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-447/out/precommit/personality/provided.sh
git revision master / ff96485
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/4/artifact/out/branch-mvninstall-root.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/4/artifact/out/patch-mvninstall-root.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/4/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/4/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/4/artifact/out/patch-javac-3.1.2.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/4/testReport/
Max. process+thread count 294 (vs. ulimit of 10000)
modules C: hbase-client U: hbase-client
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/4/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Aug 5, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 231 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
-1 mvninstall 77 root in master failed.
+1 compile 22 master passed
+1 checkstyle 29 master passed
+1 shadedjars 300 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 22 master passed
0 spotbugs 71 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 70 master passed
_ Patch Compile Tests _
-1 mvninstall 10 root in the patch failed.
+1 compile 21 the patch passed
+1 javac 21 the patch passed
+1 checkstyle 28 hbase-client: The patch generated 0 new + 0 unchanged - 15 fixed = 0 total (was 15)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 267 patch has no errors when building our shaded downstream artifacts.
-1 hadoopcheck 9 The patch causes 7 errors with Hadoop v2.8.5.
-1 hadoopcheck 18 The patch causes 7 errors with Hadoop v2.9.2.
-1 hadoopcheck 26 The patch causes 7 errors with Hadoop v3.1.2.
+1 javadoc 21 the patch passed
+1 findbugs 75 the patch passed
_ Other Tests _
+1 unit 98 hbase-client in the patch passed.
+1 asflicense 10 The patch does not generate ASF License warnings.
1371
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/5/artifact/out/Dockerfile
GITHUB PR #447
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 009113c163b5 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-447/out/precommit/personality/provided.sh
git revision master / f6ece8d
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/5/artifact/out/branch-mvninstall-root.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/5/artifact/out/patch-mvninstall-root.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/5/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/5/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/5/artifact/out/patch-javac-3.1.2.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/5/testReport/
Max. process+thread count 289 (vs. ulimit of 10000)
modules C: hbase-client U: hbase-client
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/5/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Aug 5, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 80 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
-1 mvninstall 11 root in master failed.
+1 compile 23 master passed
+1 checkstyle 26 master passed
+1 shadedjars 259 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 18 master passed
0 spotbugs 65 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 64 master passed
_ Patch Compile Tests _
-1 mvninstall 12 root in the patch failed.
+1 compile 24 the patch passed
+1 javac 24 the patch passed
+1 checkstyle 27 hbase-client: The patch generated 0 new + 0 unchanged - 15 fixed = 0 total (was 15)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 261 patch has no errors when building our shaded downstream artifacts.
-1 hadoopcheck 10 The patch causes 7 errors with Hadoop v2.8.5.
-1 hadoopcheck 20 The patch causes 7 errors with Hadoop v2.9.2.
-1 hadoopcheck 31 The patch causes 7 errors with Hadoop v3.1.2.
+1 javadoc 25 the patch passed
+1 findbugs 83 the patch passed
_ Other Tests _
+1 unit 100 hbase-client in the patch passed.
+1 asflicense 9 The patch does not generate ASF License warnings.
1127
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/6/artifact/out/Dockerfile
GITHUB PR #447
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 857cf304a565 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-447/out/precommit/personality/provided.sh
git revision master / f6ece8d
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/6/artifact/out/branch-mvninstall-root.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/6/artifact/out/patch-mvninstall-root.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/6/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/6/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/6/artifact/out/patch-javac-3.1.2.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/6/testReport/
Max. process+thread count 291 (vs. ulimit of 10000)
modules C: hbase-client U: hbase-client
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/6/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Aug 5, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 64 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 371 master passed
+1 compile 26 master passed
+1 checkstyle 32 master passed
+1 shadedjars 341 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 23 master passed
0 spotbugs 82 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 79 master passed
_ Patch Compile Tests _
+1 mvninstall 381 the patch passed
-1 compile 18 hbase-client in the patch failed.
-1 javac 18 hbase-client in the patch failed.
+1 checkstyle 34 hbase-client: The patch generated 0 new + 0 unchanged - 15 fixed = 0 total (was 15)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 338 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1181 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 23 the patch passed
+1 findbugs 129 the patch passed
_ Other Tests _
+1 unit 192 hbase-client in the patch passed.
+1 asflicense 23 The patch does not generate ASF License warnings.
3706
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/7/artifact/out/Dockerfile
GITHUB PR #447
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 2df234e7247a 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-447/out/precommit/personality/provided.sh
git revision master / 66a2fc5
Default Java 1.8.0_181
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/7/artifact/out/patch-compile-hbase-client.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/7/artifact/out/patch-compile-hbase-client.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/7/testReport/
Max. process+thread count 295 (vs. ulimit of 10000)
modules C: hbase-client U: hbase-client
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/7/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Aug 5, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 200 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 344 master passed
+1 compile 24 master passed
+1 checkstyle 33 master passed
+1 shadedjars 290 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 22 master passed
0 spotbugs 72 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 70 master passed
_ Patch Compile Tests _
+1 mvninstall 322 the patch passed
+1 compile 25 the patch passed
+1 javac 25 the patch passed
+1 checkstyle 33 hbase-client: The patch generated 0 new + 0 unchanged - 15 fixed = 0 total (was 15)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 293 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 997 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 21 the patch passed
+1 findbugs 77 the patch passed
_ Other Tests _
+1 unit 110 hbase-client in the patch passed.
+1 asflicense 11 The patch does not generate ASF License warnings.
3261
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/8/artifact/out/Dockerfile
GITHUB PR #447
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 4f25ab9b6fb7 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-447/out/precommit/personality/provided.sh
git revision master / 773414f
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/8/testReport/
Max. process+thread count 241 (vs. ulimit of 10000)
modules C: hbase-client U: hbase-client
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/8/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Aug 5, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 40 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 307 master passed
+1 compile 24 master passed
+1 checkstyle 29 master passed
+1 shadedjars 277 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 23 master passed
0 spotbugs 69 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 66 master passed
_ Patch Compile Tests _
+1 mvninstall 296 the patch passed
+1 compile 24 the patch passed
+1 javac 24 the patch passed
+1 checkstyle 28 hbase-client: The patch generated 0 new + 0 unchanged - 15 fixed = 0 total (was 15)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 263 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 923 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 22 the patch passed
+1 findbugs 72 the patch passed
_ Other Tests _
+1 unit 104 hbase-client in the patch passed.
+1 asflicense 11 The patch does not generate ASF License warnings.
2874
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/9/artifact/out/Dockerfile
GITHUB PR #447
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 4b4eeeebb6dc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-447/out/precommit/personality/provided.sh
git revision master / b021c36
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/9/testReport/
Max. process+thread count 294 (vs. ulimit of 10000)
modules C: hbase-client U: hbase-client
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/9/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Aug 5, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 88 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
-1 mvninstall 11 root in master failed.
-1 compile 22 hbase-client in master failed.
+1 checkstyle 31 master passed
+1 shadedjars 297 branch has no errors when building our shaded downstream artifacts.
-1 javadoc 21 hbase-client in master failed.
0 spotbugs 343 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 23 hbase-client in master failed.
_ Patch Compile Tests _
-1 mvninstall 11 root in the patch failed.
-1 compile 21 hbase-client in the patch failed.
-1 javac 21 hbase-client in the patch failed.
+1 checkstyle 33 hbase-client: The patch generated 0 new + 0 unchanged - 15 fixed = 0 total (was 15)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 315 patch has no errors when building our shaded downstream artifacts.
-1 hadoopcheck 9 The patch causes 7 errors with Hadoop v2.8.5.
-1 hadoopcheck 19 The patch causes 7 errors with Hadoop v2.9.2.
-1 hadoopcheck 28 The patch causes 7 errors with Hadoop v3.1.2.
-1 javadoc 21 hbase-client in the patch failed.
-1 findbugs 23 hbase-client in the patch failed.
_ Other Tests _
-1 unit 21 hbase-client in the patch failed.
+1 asflicense 10 The patch does not generate ASF License warnings.
1038
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/11/artifact/out/Dockerfile
GITHUB PR #447
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 30e9142f0898 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-447/out/precommit/personality/provided.sh
git revision master / 8411668
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/11/artifact/out/branch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/11/artifact/out/branch-compile-hbase-client.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/11/artifact/out/branch-javadoc-hbase-client.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/11/artifact/out/branch-findbugs-hbase-client.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/11/artifact/out/patch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/11/artifact/out/patch-compile-hbase-client.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/11/artifact/out/patch-compile-hbase-client.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/11/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/11/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/11/artifact/out/patch-javac-3.1.2.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/11/artifact/out/patch-javadoc-hbase-client.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/11/artifact/out/patch-findbugs-hbase-client.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/11/artifact/out/patch-unit-hbase-client.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/11/testReport/
Max. process+thread count 77 (vs. ulimit of 10000)
modules C: hbase-client U: hbase-client
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/11/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Aug 5, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 158 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 415 master passed
+1 compile 36 master passed
+1 checkstyle 40 master passed
+1 shadedjars 380 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 27 master passed
0 spotbugs 90 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 86 master passed
_ Patch Compile Tests _
+1 mvninstall 402 the patch passed
+1 compile 29 the patch passed
+1 javac 29 the patch passed
+1 checkstyle 38 hbase-client: The patch generated 0 new + 0 unchanged - 15 fixed = 0 total (was 15)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 326 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1314 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 25 the patch passed
+1 findbugs 90 the patch passed
_ Other Tests _
+1 unit 115 hbase-client in the patch passed.
+1 asflicense 14 The patch does not generate ASF License warnings.
3983
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/10/artifact/out/Dockerfile
GITHUB PR #447
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 425fed2790d9 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-447/out/precommit/personality/provided.sh
git revision master / 8411668
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/10/testReport/
Max. process+thread count 260 (vs. ulimit of 10000)
modules C: hbase-client U: hbase-client
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/10/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet HorizonNet merged commit da114ac into apache:master Aug 5, 2019
@HorizonNet HorizonNet deleted the HBASE-22785 branch August 5, 2019 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saintstack saintstack saintstack approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HorizonNet @Apache-HBase @saintstack