Skip to content

HBASE-25983 javadoc generation fails on openjdk-11.0.11+9 #4837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2022
Merged

HBASE-25983 javadoc generation fails on openjdk-11.0.11+9 #4837

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 45 additions & 14 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,7 +782,12 @@
comes in via hbase-thirdparty hbase-shaded-netty-->
<netty.hadoop.version>3.10.5.Final</netty.hadoop.version>
<!-- end HBASE-15925 default hadoop compatibility values -->
<audience-annotations.version>0.5.0</audience-annotations.version>
<audience-annotations.version>0.13.0</audience-annotations.version>
<!--
The version used when generating javadoc, 0.13.0 is the latest version which supports jdk8.
When building with jdk11, we will use 0.14.1, please see the build-with-jdk11 profile.
-->
<javadoc.audience-annotations.version>0.13.0</javadoc.audience-annotations.version>
<avro.version>1.11.0</avro.version>
<caffeine.version>2.8.1</caffeine.version>
<commons-codec.version>1.13</commons-codec.version>
Expand Down Expand Up @@ -933,8 +938,7 @@
this parameter by invoking mvn with -Dbuild.id=$BUILD_ID-->
<build.id>${maven.build.timestamp}</build.id>
<shell-executable>bash</shell-executable>
<!-- TODO HBASE-15041 clean up our javadocs so jdk8 linter can be used.
property as of javadoc-plugin 3.0.0 -->
<!-- Still need this to ignore some errors when building javadoc-->
<doclint>none</doclint>
</properties>
<!-- Sorted by groups of dependencies then groupId and artifactId -->
Expand Down Expand Up @@ -1767,8 +1771,6 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<source>${compileSource}</source>
<target>${compileSource}</target>
<showWarnings>true</showWarnings>
<showDeprecation>false</showDeprecation>
<useIncrementalCompilation>false</useIncrementalCompilation>
Expand Down Expand Up @@ -3010,7 +3012,7 @@
<docletArtifact>
<groupId>org.apache.yetus</groupId>
<artifactId>audience-annotations</artifactId>
<version>${audience-annotations.version}</version>
<version>${javadoc.audience-annotations.version}</version>
</docletArtifact>
<useStandardDocletOptions>true</useStandardDocletOptions>
<destDir>apidocs</destDir>
Expand Down Expand Up @@ -3067,7 +3069,7 @@
<docletArtifact>
<groupId>org.apache.yetus</groupId>
<artifactId>audience-annotations</artifactId>
<version>${audience-annotations.version}</version>
<version>${javadoc.audience-annotations.version}</version>
</docletArtifact>
<useStandardDocletOptions>true</useStandardDocletOptions>
<destDir>testapidocs</destDir>
Expand Down Expand Up @@ -3157,18 +3159,17 @@
<profile>
<id>build-with-jdk8</id>
<activation>
<jdk>[1.8,)</jdk>
<jdk>1.8</jdk>
</activation>
<build>
<pluginManagement>
<plugins/>
</pluginManagement>
</build>
<properties>
<maven.compiler.source>${compileSource}</maven.compiler.source>
<maven.compiler.target>${compileSource}</maven.compiler.target>
</properties>
</profile>
<profile>
<id>build-with-jdk11</id>
<activation>
<jdk>[1.11,)</jdk>
<jdk>[11,)</jdk>
</activation>
<properties>
<maven.compiler.release>${releaseTarget}</maven.compiler.release>
Expand All @@ -3188,7 +3189,37 @@
TODO: replicate logic for windows
-->
<surefire.Xmx>2200m</surefire.Xmx>
<!--
com.sun.javadoc and com.sun.tools.doclets are both deprecated in java 11 and will
fail the javadoc generating, so we need to use yetus 0.14.1 where it uses jdk.javadoc
and jdk.javadoc.doclet instead
-->
<javadoc.audience-annotations.version>0.14.1</javadoc.audience-annotations.version>
</properties>
<build>
<pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>${maven.javadoc.version}</version>
<configuration>
<source>${compileSource}</source>
<!--
Need to add this option to ignore the source errors, epsecially that we reference
test code in hbase-testing-util's main code.
-->
<additionalOptions>--ignore-source-errors</additionalOptions>
<additionalJOptions>
<additionalJOption>-J-Xmx2G</additionalJOption>
<additionalJOption>-J--add-exports</additionalJOption>
<additionalJOption>-Jjdk.javadoc/jdk.javadoc.internal.tool=ALL-UNNAMED</additionalJOption>
</additionalJOptions>
</configuration>
</plugin>
</plugins>
</pluginManagement>
</build>
</profile>
<!-- profile activated by the Jenkins patch testing job -->
<profile>
Expand Down