Skip to content

HBASE-27437 TestHeapSize is flaky #4841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2022
Merged

HBASE-27437 TestHeapSize is flaky #4841

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 29 additions & 13 deletions hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHeapSize.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
*/
package org.apache.hadoop.hbase.io;

import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.lessThan;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;

Expand All @@ -25,13 +27,16 @@
import java.lang.management.RuntimeMXBean;
import java.nio.ByteBuffer;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.LinkedList;
import java.util.List;
import java.util.Map;
import java.util.TreeMap;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentSkipListMap;
import java.util.concurrent.CopyOnWriteArrayList;
import java.util.concurrent.CopyOnWriteArraySet;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.concurrent.atomic.AtomicLong;
Expand Down Expand Up @@ -69,7 +74,6 @@
import org.apache.hadoop.hbase.testclassification.IOTests;
import org.apache.hadoop.hbase.testclassification.SmallTests;
import org.apache.hadoop.hbase.util.ClassSize;
import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
import org.junit.BeforeClass;
import org.junit.ClassRule;
import org.junit.Test;
Expand Down Expand Up @@ -602,18 +606,30 @@ public void testObjectSize() throws IOException {
}
}

@Test
public void testAutoCalcFixedOverHead() {
Class[] classList = new Class[] { HFileContext.class, HRegion.class, BlockCacheKey.class,
HFileBlock.class, HStore.class, LruBlockCache.class, StoreContext.class };
for (Class cl : classList) {
// do estimate in advance to ensure class is loaded
ClassSize.estimateBase(cl, false);

long startTime = EnvironmentEdgeManager.currentTime();
ClassSize.estimateBase(cl, false);
long endTime = EnvironmentEdgeManager.currentTime();
assertTrue(endTime - startTime < 5);
private long calcFixedOverhead(List<Class<?>> classList) {
long overhead = 0;
for (Class<?> clazz : classList) {
overhead += ClassSize.estimateBase(clazz, false);
}
return overhead;
}

@Test
public void testAutoCalcFixedOverhead() throws InterruptedException {
List<Class<?>> classList = Arrays.asList(HFileContext.class, HRegion.class, BlockCacheKey.class,
HFileBlock.class, HStore.class, LruBlockCache.class, StoreContext.class);
for (int i = 0; i < 10; i++) {
// warm up
calcFixedOverhead(classList);
}
long startNs = System.nanoTime();
long overhead = 0;
for (int i = 0; i < 100; i++) {
overhead += calcFixedOverhead(classList);
}
long costNs = System.nanoTime() - startNs;
LOG.info("overhead = {}, cost {} ns", overhead, costNs);
// the single computation cost should be less than 5ms
assertThat(costNs, lessThan(TimeUnit.MILLISECONDS.toNanos(5) * classList.size() * 100));
}
}