You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have tested the change in our internal dev cluster. Before the change, all the RS used to crash and after the change it doesn't crash. Please review.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1.3 Compile Tests _
+1
mvninstall
424
branch-1.3 passed
+1
compile
39
branch-1.3 passed
+1
checkstyle
80
branch-1.3 passed
-1
shadedjars
12
branch has 10 errors when building our shaded downstream artifacts.
+1
javadoc
36
branch-1.3 passed
0
spotbugs
138
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
136
branch-1.3 passed
_ Patch Compile Tests _
+1
mvninstall
101
the patch passed
+1
compile
38
the patch passed
+1
javac
38
the patch passed
+1
checkstyle
94
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
-1
shadedjars
10
patch has 10 errors when building our shaded downstream artifacts.
+1
hadoopcheck
537
Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1.3 Compile Tests _
+1
mvninstall
428
branch-1.3 passed
+1
compile
35
branch-1.3 passed with JDK v1.8.0_222
+1
compile
36
branch-1.3 passed with JDK v1.7.0_232
+1
checkstyle
85
branch-1.3 passed
+1
shadedjars
145
branch has no errors when building our shaded downstream artifacts.
+1
javadoc
35
branch-1.3 passed with JDK v1.8.0_222
+1
javadoc
34
branch-1.3 passed with JDK v1.7.0_232
0
spotbugs
154
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
150
branch-1.3 passed
_ Patch Compile Tests _
+1
mvninstall
93
the patch passed
+1
compile
36
the patch passed with JDK v1.8.0_222
+1
javac
36
the patch passed
+1
compile
37
the patch passed with JDK v1.7.0_232
+1
javac
37
the patch passed
+1
checkstyle
81
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedjars
136
patch has no errors when building our shaded downstream artifacts.
+1
hadoopcheck
514
Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1.3 Compile Tests _
+1
mvninstall
464
branch-1.3 passed
+1
compile
51
branch-1.3 passed with JDK v1.8.0_222
+1
compile
54
branch-1.3 passed with JDK v1.7.0_232
+1
checkstyle
109
branch-1.3 passed
+1
shadedjars
188
branch has no errors when building our shaded downstream artifacts.
+1
javadoc
56
branch-1.3 passed with JDK v1.8.0_222
+1
javadoc
60
branch-1.3 passed with JDK v1.7.0_232
0
spotbugs
204
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
201
branch-1.3 passed
_ Patch Compile Tests _
+1
mvninstall
134
the patch passed
+1
compile
50
the patch passed with JDK v1.8.0_222
+1
javac
50
the patch passed
+1
compile
51
the patch passed with JDK v1.7.0_232
+1
javac
51
the patch passed
+1
checkstyle
117
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedjars
199
patch has no errors when building our shaded downstream artifacts.
+1
hadoopcheck
691
Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1.3 Compile Tests _
+1
mvninstall
446
branch-1.3 passed
+1
compile
41
branch-1.3 passed with JDK v1.8.0_222
+1
compile
39
branch-1.3 passed with JDK v1.7.0_232
+1
checkstyle
92
branch-1.3 passed
+1
shadedjars
166
branch has no errors when building our shaded downstream artifacts.
+1
javadoc
40
branch-1.3 passed with JDK v1.8.0_222
+1
javadoc
39
branch-1.3 passed with JDK v1.7.0_232
0
spotbugs
165
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
162
branch-1.3 passed
_ Patch Compile Tests _
+1
mvninstall
96
the patch passed
+1
compile
38
the patch passed with JDK v1.8.0_222
+1
javac
38
the patch passed
+1
compile
40
the patch passed with JDK v1.7.0_232
+1
javac
40
the patch passed
+1
checkstyle
88
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedjars
151
patch has no errors when building our shaded downstream artifacts.
+1
hadoopcheck
564
Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1.3 Compile Tests _
+1
mvninstall
461
branch-1.3 passed
+1
compile
44
branch-1.3 passed with JDK v1.8.0_222
+1
compile
46
branch-1.3 passed with JDK v1.7.0_232
+1
checkstyle
108
branch-1.3 passed
+1
shadedjars
198
branch has no errors when building our shaded downstream artifacts.
+1
javadoc
42
branch-1.3 passed with JDK v1.8.0_222
+1
javadoc
47
branch-1.3 passed with JDK v1.7.0_232
0
spotbugs
202
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
197
branch-1.3 passed
_ Patch Compile Tests _
+1
mvninstall
140
the patch passed
+1
compile
45
the patch passed with JDK v1.8.0_222
+1
javac
45
the patch passed
+1
compile
49
the patch passed with JDK v1.7.0_232
+1
javac
49
the patch passed
+1
checkstyle
104
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedjars
186
patch has no errors when building our shaded downstream artifacts.
+1
hadoopcheck
645
Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1.3 Compile Tests _
+1
mvninstall
457
branch-1.3 passed
+1
compile
34
branch-1.3 passed with JDK v1.8.0_222
+1
compile
37
branch-1.3 passed with JDK v1.7.0_232
+1
checkstyle
88
branch-1.3 passed
+1
shadedjars
150
branch has no errors when building our shaded downstream artifacts.
+1
javadoc
35
branch-1.3 passed with JDK v1.8.0_222
+1
javadoc
35
branch-1.3 passed with JDK v1.7.0_232
0
spotbugs
150
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
147
branch-1.3 passed
_ Patch Compile Tests _
+1
mvninstall
94
the patch passed
+1
compile
36
the patch passed with JDK v1.8.0_222
+1
javac
36
the patch passed
+1
compile
38
the patch passed with JDK v1.7.0_232
+1
javac
38
the patch passed
+1
checkstyle
84
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedjars
140
patch has no errors when building our shaded downstream artifacts.
+1
hadoopcheck
514
Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1.3 Compile Tests _
+1
mvninstall
448
branch-1.3 passed
+1
compile
38
branch-1.3 passed with JDK v1.8.0_222
+1
compile
40
branch-1.3 passed with JDK v1.7.0_232
+1
checkstyle
84
branch-1.3 passed
+1
shadedjars
166
branch has no errors when building our shaded downstream artifacts.
+1
javadoc
36
branch-1.3 passed with JDK v1.8.0_222
+1
javadoc
37
branch-1.3 passed with JDK v1.7.0_232
0
spotbugs
162
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
158
branch-1.3 passed
_ Patch Compile Tests _
+1
mvninstall
99
the patch passed
+1
compile
35
the patch passed with JDK v1.8.0_222
+1
javac
35
the patch passed
+1
compile
40
the patch passed with JDK v1.7.0_232
+1
javac
40
the patch passed
+1
checkstyle
81
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedjars
146
patch has no errors when building our shaded downstream artifacts.
+1
hadoopcheck
542
Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
Ran failing test TestSimpleRegionNormalizerOnCluster few time on my local setup and it succeeds.
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 36.186 s - in org.apache.hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
@apurtell@Apache9 could you guys please review again ?
Surprisingly qa bot came all green for branch-2 and master branches:
branch-2: #500
master: #499
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1.3 Compile Tests _
+1
mvninstall
448
branch-1.3 passed
+1
compile
35
branch-1.3 passed with JDK v1.8.0_222
+1
compile
38
branch-1.3 passed with JDK v1.7.0_232
+1
checkstyle
87
branch-1.3 passed
+1
shadedjars
153
branch has no errors when building our shaded downstream artifacts.
+1
javadoc
34
branch-1.3 passed with JDK v1.8.0_222
+1
javadoc
37
branch-1.3 passed with JDK v1.7.0_232
0
spotbugs
162
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
157
branch-1.3 passed
_ Patch Compile Tests _
+1
mvninstall
97
the patch passed
+1
compile
35
the patch passed with JDK v1.8.0_222
+1
javac
35
the patch passed
+1
compile
37
the patch passed with JDK v1.7.0_232
+1
javac
37
the patch passed
+1
checkstyle
81
the patch passed
+1
whitespace
1
The patch has no whitespace issues.
+1
shadedjars
145
patch has no errors when building our shaded downstream artifacts.
+1
hadoopcheck
534
Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1.3 Compile Tests _
+1
mvninstall
482
branch-1.3 passed
+1
compile
57
branch-1.3 passed
+1
checkstyle
112
branch-1.3 passed
-1
shadedjars
15
branch has 10 errors when building our shaded downstream artifacts.
+1
javadoc
44
branch-1.3 passed
0
spotbugs
169
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
166
branch-1.3 passed
_ Patch Compile Tests _
+1
mvninstall
141
the patch passed
+1
compile
55
the patch passed
+1
javac
55
the patch passed
+1
checkstyle
109
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
-1
shadedjars
14
patch has 10 errors when building our shaded downstream artifacts.
+1
hadoopcheck
696
Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1.3 Compile Tests _
+1
mvninstall
477
branch-1.3 passed
+1
compile
37
branch-1.3 passed with JDK v1.8.0_222
+1
compile
39
branch-1.3 passed with JDK v1.7.0_232
+1
checkstyle
87
branch-1.3 passed
+1
shadedjars
150
branch has no errors when building our shaded downstream artifacts.
+1
javadoc
39
branch-1.3 passed with JDK v1.8.0_222
+1
javadoc
38
branch-1.3 passed with JDK v1.7.0_232
0
spotbugs
159
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
156
branch-1.3 passed
_ Patch Compile Tests _
+1
mvninstall
103
the patch passed
+1
compile
35
the patch passed with JDK v1.8.0_222
+1
javac
35
the patch passed
+1
compile
37
the patch passed with JDK v1.7.0_232
+1
javac
37
the patch passed
+1
checkstyle
80
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedjars
136
patch has no errors when building our shaded downstream artifacts.
+1
hadoopcheck
556
Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1.3 Compile Tests _
-1
mvninstall
411
root in branch-1.3 failed.
-1
compile
35
hbase-server in branch-1.3 failed.
+1
checkstyle
90
branch-1.3 passed
-1
shadedjars
14
branch has 10 errors when building our shaded downstream artifacts.
+1
javadoc
43
branch-1.3 passed
0
spotbugs
99
Used deprecated FindBugs config; considering switching to SpotBugs.
-1
findbugs
40
hbase-server in branch-1.3 failed.
_ Patch Compile Tests _
-1
mvninstall
68
root in the patch failed.
-1
compile
39
hbase-server in the patch failed.
-1
javac
39
hbase-server in the patch failed.
+1
checkstyle
86
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
-1
shadedjars
10
patch has 10 errors when building our shaded downstream artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1.3 Compile Tests _
+1
mvninstall
471
branch-1.3 passed
+1
compile
41
branch-1.3 passed
+1
checkstyle
105
branch-1.3 passed
-1
shadedjars
12
branch has 10 errors when building our shaded downstream artifacts.
+1
javadoc
40
branch-1.3 passed
0
spotbugs
164
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
160
branch-1.3 passed
_ Patch Compile Tests _
+1
mvninstall
123
the patch passed
+1
compile
43
the patch passed
+1
javac
43
the patch passed
+1
checkstyle
100
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
-1
shadedjars
10
patch has 10 errors when building our shaded downstream artifacts.
+1
hadoopcheck
664
Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1.3 Compile Tests _
+1
mvninstall
510
branch-1.3 passed
+1
compile
49
branch-1.3 passed with JDK v1.8.0_222
+1
compile
58
branch-1.3 passed with JDK v1.7.0_232
+1
checkstyle
127
branch-1.3 passed
+1
shadedjars
226
branch has no errors when building our shaded downstream artifacts.
+1
javadoc
46
branch-1.3 passed with JDK v1.8.0_222
+1
javadoc
53
branch-1.3 passed with JDK v1.7.0_232
0
spotbugs
227
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
223
branch-1.3 passed
_ Patch Compile Tests _
+1
mvninstall
164
the patch passed
+1
compile
53
the patch passed with JDK v1.8.0_222
+1
javac
53
the patch passed
+1
compile
54
the patch passed with JDK v1.7.0_232
+1
javac
54
the patch passed
+1
checkstyle
125
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedjars
224
patch has no errors when building our shaded downstream artifacts.
+1
hadoopcheck
788
Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have tested the change in our internal dev cluster. Before the change, all the RS used to crash and after the change it doesn't crash. Please review.