-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-27720 TestClusterRestartFailover is flakey due to metrics assertion #5110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-27720 TestClusterRestartFailover is flakey due to metrics assertion #5110
Conversation
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
| .getServerNode(SERVER_FOR_TEST); | ||
| assertNull("serverNode should be deleted after SCP finished", serverNode); | ||
|
|
||
| // this test has been flakey. When it is rerun by surefire, the underlying minicluster isn't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can not reset the metrics system in the AfterClass method or BeforeClass method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Posted a new patch that (I think) will reset the master metrics each time the mini cluster is started.
|
https://issues.apache.org/jira/browse/HBASE-14166 Seems added in this issue. |
9e49b1f to
e82f925
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
…tion (#5110) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit f36587c)
…tion (#5110) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit f36587c)
…tion (#5110) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit f36587c)
…tion (apache#5110) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit f36587c) (cherry picked from commit 34e05b7) Change-Id: Ide31e7d4473061e223752c213c6836f5a53a1979
This test has been flakey. When it is rerun by surefire, the underlying minicluster isn't completely cleaned. specifically, the metics system isn't reset. The result is an otherwise successful re-run is failed because there's 8 or 12 SCPcounts instead of the 4 that a single run of the test would otherwise produce. Thus, assert of a multiple of 4.