Skip to content

HBASE-28690 Aborting Active HMaster is not rejecting reportRegionStateTransition if procedure is initialised by next Active master #6180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 29, 2024
Merged

HBASE-28690 Aborting Active HMaster is not rejecting reportRegionStateTransition if procedure is initialised by next Active master #6180

merged 2 commits into from
Aug 29, 2024

Conversation

@Umeshkumar9414
Copy link
Contributor

@Umeshkumar9414 Umeshkumar9414 commented Aug 28, 2024

Added masterActiveTime as fencing token for remote procedures

Umeshkumar9414 and others added 2 commits August 28, 2024 07:07
@Umeshkumar9414
HBASE-28690 Aborting Active HMaster is not rejecting reportRegionStat…
9d504c9 
…eTransition if procedure is initialised by next Active master (apache#6136)

Added masterActiveTime as fencing token for remote procedures

Signed-off-by: Duo Zhang <[email protected]>
Reviewed-by: Aman Poonia <[email protected]>
HBASE-28690 added comment for buildCloseRegionRequest
7a9d381
@Apache-HBase
Copy link

Apache-HBase commented Aug 28, 2024

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 8s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 buf 0m 0s buf was not available.
+0 🆗 buf 0m 0s buf was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ branch-2.5 Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 4m 28s branch-2.5 passed
+1 💚 compile 5m 21s branch-2.5 passed
+1 💚 checkstyle 1m 21s branch-2.5 passed
+1 💚 spotbugs 5m 58s branch-2.5 passed
+1 💚 spotless 1m 1s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for patch
+1 💚 mvninstall 3m 51s the patch passed
+1 💚 compile 4m 55s the patch passed
+1 💚 cc 4m 55s the patch passed
+1 💚 javac 4m 55s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 37s the patch passed
+1 💚 spotbugs 5m 13s the patch passed
+1 💚 hadoopcheck 30m 5s Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6 3.4.0.
+1 💚 hbaseprotoc 2m 20s the patch passed
+1 💚 spotless 1m 13s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 54s The patch does not generate ASF License warnings.
72m 55s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6180/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6180
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname Linux e6c6ebbddc48 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.5 / 7a9d381
Default Java Eclipse Adoptium-11.0.23+9
Max. process+thread count 82 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-procedure hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6180/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Aug 28, 2024

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 44s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for branch
+1 💚 mvninstall 2m 54s branch-2.5 passed
+1 💚 compile 1m 58s branch-2.5 passed
+1 💚 javadoc 1m 6s branch-2.5 passed
+1 💚 shadedjars 5m 18s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 2m 43s the patch passed
+1 💚 compile 1m 55s the patch passed
+1 💚 javac 1m 55s the patch passed
+1 💚 javadoc 1m 3s the patch passed
+1 💚 shadedjars 5m 17s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 0m 30s hbase-protocol-shaded in the patch passed.
+1 💚 unit 8m 5s hbase-client in the patch passed.
+1 💚 unit 1m 29s hbase-procedure in the patch passed.
+1 💚 unit 186m 34s hbase-server in the patch passed.
224m 25s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6180/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6180
Optional Tests javac javadoc unit compile shadedjars
uname Linux 7192d2fd5c88 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.5 / 7a9d381
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6180/1/testReport/
Max. process+thread count 4232 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-procedure hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6180/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Aug 28, 2024

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 10s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 3m 55s branch-2.5 passed
+1 💚 compile 2m 11s branch-2.5 passed
+1 💚 javadoc 1m 25s branch-2.5 passed
+1 💚 shadedjars 6m 9s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 3m 5s the patch passed
+1 💚 compile 2m 5s the patch passed
+1 💚 javac 2m 5s the patch passed
+1 💚 javadoc 1m 34s the patch passed
+1 💚 shadedjars 6m 17s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 0m 27s hbase-protocol-shaded in the patch passed.
+1 💚 unit 8m 18s hbase-client in the patch passed.
+1 💚 unit 1m 45s hbase-procedure in the patch passed.
+1 💚 unit 198m 33s hbase-server in the patch passed.
242m 20s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6180/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #6180
Optional Tests javac javadoc unit compile shadedjars
uname Linux 63f1701f37ff 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.5 / 7a9d381
Default Java Temurin-1.8.0_412-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6180/1/testReport/
Max. process+thread count 4104 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-procedure hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6180/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Aug 28, 2024

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 42s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for branch
+1 💚 mvninstall 3m 0s branch-2.5 passed
+1 💚 compile 2m 9s branch-2.5 passed
+1 💚 javadoc 1m 14s branch-2.5 passed
+1 💚 shadedjars 5m 14s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for patch
+1 💚 mvninstall 2m 53s the patch passed
+1 💚 compile 2m 9s the patch passed
+1 💚 javac 2m 9s the patch passed
+1 💚 javadoc 1m 15s the patch passed
+1 💚 shadedjars 5m 11s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 0m 35s hbase-protocol-shaded in the patch passed.
+1 💚 unit 8m 15s hbase-client in the patch passed.
+1 💚 unit 1m 26s hbase-procedure in the patch passed.
+1 💚 unit 213m 27s hbase-server in the patch passed.
252m 54s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6180/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #6180
Optional Tests javac javadoc unit compile shadedjars
uname Linux 73d4e6612b84 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.5 / 7a9d381
Default Java Eclipse Adoptium-11.0.23+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6180/1/testReport/
Max. process+thread count 4328 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-procedure hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6180/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 merged commit e15be23 into apache:branch-2.5 Aug 29, 2024
sanjeet006py pushed a commit to sanjeet006py/hbase that referenced this pull request Aug 24, 2025
@Umeshkumar9414
HBASE-28690 Aborting Active HMaster is not rejecting reportRegionStat…
a85051b 
…eTransition if procedure is initialised by next Active master (apache#6180)

Added masterActiveTime as fencing token for remote procedures

Signed-off-by: Duo Zhang <[email protected]>
Reviewed-by: Aman Poonia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9 Apache9 Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Umeshkumar9414 @Apache-HBase @Apache9