Skip to content

Conversation

@sanjeet006py
Copy link
Contributor

@sanjeet006py sanjeet006py commented Jun 29, 2025

Cherry-pick of #6868 for HBase 2.

Modifications done for HBase 2:

  • Sync HBase client read path is different in HBase 2 from HBase 3 and 4. Thus, modifications have been done to handle only this part.
  • In HBase 3 and 4, scan metrics by region are available for sync and async client both for STRONG consistency and TIMELINE consistency. But in HBase 2, for sync client with TIMELINE consistency, scan metrics by region is not supported. If users enable the flag then in constructor of ClientScanner we disable it and log a warning stating the same.
  • In ClientScanner used by sync clients, two modifications have been done to add support for scan metrics by region:
    - In moveToNextRegion() we conditionally call scanMetrics.moveToNextRegion().
    - We initialize the ScanMetricsRegionInfo at same time when we capture current region being scanned in ClientScanner. Code to capture current region being scanned was already there in ClientScanner.
  • From HBase 3 onwards, scan metrics for NSRE count and milliseconds spent b/w two consecutive next() calls, are not used. But in HBase 2 both above metrics are used so, they also had to be initialized in ScanMetrics.moveToNextRegion() and ITs had to be adjusted accordingly.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@ndimiduk ndimiduk requested a review from virajjasani June 30, 2025 10:09
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 55s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ branch-2.6 Compile Tests _
+0 🆗 mvndep 0m 35s Maven dependency ordering for branch
+1 💚 mvninstall 4m 12s branch-2.6 passed
+1 💚 compile 7m 36s branch-2.6 passed
+1 💚 checkstyle 1m 24s branch-2.6 passed
+1 💚 spotbugs 12m 5s branch-2.6 passed
+1 💚 spotless 1m 7s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 37s the patch passed
+1 💚 compile 7m 25s the patch passed
-0 ⚠️ javac 7m 25s /results-compile-javac-root.txt root generated 2 new + 1268 unchanged - 2 fixed = 1270 total (was 1270)
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 40s the patch passed
+1 💚 spotbugs 13m 57s the patch passed
+1 💚 hadoopcheck 19m 21s Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚 spotless 0m 48s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 37s The patch does not generate ASF License warnings.
78m 45s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7132/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7132
Optional Tests dupname asflicense codespell detsecrets spotless javac spotbugs checkstyle compile hadoopcheck hbaseanti
uname Linux 19896351b483 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / 19457bb
Default Java Eclipse Adoptium-11.0.23+9
Max. process+thread count 179 (vs. ulimit of 30000)
modules C: hbase-client hbase-server . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7132/2/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 58s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 3m 18s branch-2.6 passed
+1 💚 compile 2m 15s branch-2.6 passed
+1 💚 javadoc 2m 45s branch-2.6 passed
+1 💚 shadedjars 6m 37s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 3m 18s the patch passed
+1 💚 compile 2m 12s the patch passed
+1 💚 javac 2m 12s the patch passed
+1 💚 javadoc 2m 51s the patch passed
+1 💚 shadedjars 6m 14s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 37m 40s /patch-unit-root.txt root in the patch failed.
71m 27s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7132/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #7132
Optional Tests javac javadoc unit compile shadedjars
uname Linux 319b98ff678a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / 19457bb
Default Java Temurin-1.8.0_412-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7132/2/testReport/
Max. process+thread count 2439 (vs. ulimit of 30000)
modules C: hbase-client hbase-server . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7132/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 52s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 3m 25s branch-2.6 passed
+1 💚 compile 2m 23s branch-2.6 passed
+1 💚 javadoc 3m 11s branch-2.6 passed
+1 💚 shadedjars 7m 51s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 3m 25s the patch passed
+1 💚 compile 3m 9s the patch passed
+1 💚 javac 3m 9s the patch passed
-0 ⚠️ javadoc 0m 28s /results-javadoc-javadoc-hbase-client.txt hbase-client generated 11 new + 83 unchanged - 0 fixed = 94 total (was 83)
-0 ⚠️ javadoc 2m 23s /results-javadoc-javadoc-root.txt root generated 11 new + 199 unchanged - 0 fixed = 210 total (was 199)
+1 💚 shadedjars 6m 51s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 304m 45s root in the patch passed.
347m 31s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7132/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #7132
Optional Tests javac javadoc unit compile shadedjars
uname Linux a49221a91cea 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / 19457bb
Default Java Eclipse Adoptium-11.0.23+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7132/2/testReport/
Max. process+thread count 9047 (vs. ulimit of 30000)
modules C: hbase-client hbase-server . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7132/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 53s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 4m 17s branch-2.6 passed
+1 💚 compile 3m 6s branch-2.6 passed
+1 💚 javadoc 3m 22s branch-2.6 passed
+1 💚 shadedjars 7m 1s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 24s the patch passed
+1 💚 compile 2m 23s the patch passed
+1 💚 javac 2m 23s the patch passed
+1 💚 javadoc 3m 11s the patch passed
+1 💚 shadedjars 7m 3s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 317m 44s root in the patch passed.
360m 45s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7132/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7132
Optional Tests javac javadoc unit compile shadedjars
uname Linux 75ef32672d75 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / 19457bb
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7132/2/testReport/
Max. process+thread count 8803 (vs. ulimit of 30000)
modules C: hbase-client hbase-server . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7132/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@virajjasani virajjasani merged commit 4fde3b2 into apache:branch-2.6 Jul 2, 2025
1 check failed
virajjasani pushed a commit that referenced this pull request Jul 2, 2025
sanjeet006py added a commit to sanjeet006py/hbase that referenced this pull request Jul 3, 2025
mokai87 pushed a commit to mokai87/hbase that referenced this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants