Skip to content

Add tests and fixes for Daft integration #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2024
Merged

Add tests and fixes for Daft integration #381

merged 2 commits into from
Feb 7, 2024

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Feb 6, 2024 •
edited
Loading

  1. Adds some integration tests for Daft
  2. Realized also that our current Daft integration was implemented not on Table but on the Scan... This is now fixed and verified with integration tests

Fokko
Fokko approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @jaychia 👍

@Fokko Fokko added this to the PyIceberg 0.6.0 release milestone Feb 6, 2024
HonahX
HonahX approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @jaychia

@Fokko Fokko merged commit cec051f into apache:main Feb 7, 2024
@sungwy sungwy mentioned this pull request Feb 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fokko Fokko Fokko approved these changes

@HonahX HonahX HonahX approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

PyIceberg 0.6.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@jaychia @Fokko @HonahX