Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
5ad32b0
Initial read-only Snowflake Catalog implementation by @sfc-gh-mparmar…
sfc-gh-dhuo Dec 13, 2022
930a3f0
Add JdbcSnowflakeClientTest using mocks (#2)
dennishuo Dec 14, 2022
86b3d11
Merge branch 'main' into snowflake-catalog-initial
dennishuo Dec 14, 2022
076a14a
Add test { useJUnitPlatform() } tuple to iceberg-snowflake for
dennishuo Dec 16, 2022
a7b5aa7
Extract versions into versions.props per PR review
dennishuo Dec 17, 2022
dd5255c
Misc test-related refactors per review suggestions
dennishuo Dec 17, 2022
500b36b
Fix unsupported behaviors of loadNamedpaceMetadata and defaultWarehou…
dennishuo Dec 17, 2022
ad2c55f
Move TableIdentifier checks out of newTableOps into the
dennishuo Dec 17, 2022
7f13674
Refactor out any Namespace-related business logic from the lower
dennishuo Dec 17, 2022
58d258e
Finish migrating JdbcSnowflakeClientTest off any usage of org.junit.A…
dennishuo Dec 17, 2022
0183129
Style refactorings from review comments, expanded and moved InMemoryF…
dennishuo Dec 20, 2022
ca6deab
Fix behavior of getNamespaceMetadata to throw when the namespace doesn't
dennishuo Dec 21, 2022
b3a2842
Move private constructor to top, add assertion to test case.
dennishuo Dec 21, 2022
676d024
Define minimal ResultSetParser/QueryHarness classes to fully replace
dennishuo Dec 21, 2022
cc493d0
Update snowflake/src/main/java/org/apache/iceberg/snowflake/Snowflake…
dennishuo Dec 23, 2022
ce7e28c
Refactor style suggestions; remove debug-level logging, arguments in …
dennishuo Dec 23, 2022
2729e64
Fix precondition messages, remove getConf()
dennishuo Jan 6, 2023
4c1e79f
Clean up varargs.
dennishuo Jan 7, 2023
bc0c6ee
Make data members final, include rawJsonVal in toString for debuggabi…
dennishuo Jan 7, 2023
8240d9e
Merge branch 'main' into snowflake-catalog-initial
dennishuo Jan 9, 2023
ebe5dd6
Combine some small test cases into roundtrip test cases, misc cleanup
dennishuo Jan 10, 2023
9e9b9e6
Add comment for why a factory class is exposed for testing purposes.
dennishuo Jan 13, 2023
e8fee31
Merge remote-tracking branch 'origin/main' into snowflake-catalog-ini…
dennishuo Jan 14, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/labeler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,4 +81,6 @@ ALIYUN:
GCP:
- gcp/**/*
DELL:
- dell/**/*
- dell/**/*
SNOWFLAKE:
- snowflake/**/*
18 changes: 18 additions & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -697,6 +697,24 @@ project(':iceberg-dell') {
}
}

project(':iceberg-snowflake') {
test {
useJUnitPlatform()
}

dependencies {
implementation project(':iceberg-core')
implementation project(':iceberg-common')
implementation project(path: ':iceberg-bundled-guava', configuration: 'shadow')
implementation "com.fasterxml.jackson.core:jackson-databind"
implementation "com.fasterxml.jackson.core:jackson-core"

runtimeOnly("net.snowflake:snowflake-jdbc")

testImplementation project(path: ':iceberg-core', configuration: 'testArtifacts')
}
}

@Memoized
boolean versionFileExists() {
return file('version.txt').exists()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@
import org.apache.iceberg.CatalogProperties;
import org.apache.iceberg.ClientPoolImpl;

class JdbcClientPool extends ClientPoolImpl<Connection, SQLException> {
public class JdbcClientPool extends ClientPoolImpl<Connection, SQLException> {

private final String dbUrl;
private final Map<String, String> properties;

JdbcClientPool(String dbUrl, Map<String, String> props) {
public JdbcClientPool(String dbUrl, Map<String, String> props) {
this(
Integer.parseInt(
props.getOrDefault(
Expand All @@ -42,7 +42,7 @@ class JdbcClientPool extends ClientPoolImpl<Connection, SQLException> {
props);
}

JdbcClientPool(int poolSize, String dbUrl, Map<String, String> props) {
public JdbcClientPool(int poolSize, String dbUrl, Map<String, String> props) {
super(poolSize, SQLNonTransientConnectionException.class, true);
properties = props;
this.dbUrl = dbUrl;
Expand Down
2 changes: 2 additions & 0 deletions settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ include 'hive-metastore'
include 'nessie'
include 'gcp'
include 'dell'
include 'snowflake'

project(':api').name = 'iceberg-api'
project(':common').name = 'iceberg-common'
Expand All @@ -51,6 +52,7 @@ project(':hive-metastore').name = 'iceberg-hive-metastore'
project(':nessie').name = 'iceberg-nessie'
project(':gcp').name = 'iceberg-gcp'
project(':dell').name = 'iceberg-dell'
project(':snowflake').name = 'iceberg-snowflake'

if (null != System.getProperty("allVersions")) {
System.setProperty("flinkVersions", System.getProperty("knownFlinkVersions"))
Expand Down
Loading