[Relay][Runtime] Add VM compiler. #3139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tqchen @wweic @MarisaKirisame @weberlo @icemelon9 @zhiics final bit of VM to review tests are green. |
wweic
requested changes
May 9, 2019
include/tvm/relay/vm_compiler.h
Outdated
|
|
||
| bool IsClosure(const Function& func); | ||
| Module LambdaLift(const Module& module); | ||
| Module InlinePrimitives(const Module& module); |
|
|
||
| if __name__ == '__main__': | ||
| test_resnet() | ||
| # test_vgg() |
|
|
||
| inline std::string GenerateName(const Function& func) { | ||
| size_t hash = StructuralHash()(func); | ||
| return std::string("lifted_name") + std::to_string(hash); |
There was a problem hiding this comment.
what if hash collision? just do a unique binder
There was a problem hiding this comment.
Hash collision is low, I will just prefix function name too
Co-Authored-By: 雾雨魔理沙 <[email protected]>
wweic
approved these changes
May 10, 2019
zhiics
reviewed
May 10, 2019
tqchen
requested changes
May 10, 2019
| using ConstTensorShapeMap = NodeMap<TensorType, std::pair<Index, NDArray>>; | ||
|
|
||
| struct VMCompilerContext { | ||
| Module module; |
tqchen
approved these changes
May 10, 2019
icemelon
approved these changes
May 11, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
May 13, 2019
* Implement the VM compiler * Fix issues * Fix ASF headers * Fix test issue * Apply typo fixes. * Update src/relay/backend/vm/compiler.cc Co-Authored-By: 雾雨魔理沙 <[email protected]> * Refactor compiler * Fix * Fix * Fix in benchmark * Fix * Address comments
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 13, 2019
* Implement the VM compiler * Fix issues * Fix ASF headers * Fix test issue * Apply typo fixes. * Update src/relay/backend/vm/compiler.cc Co-Authored-By: 雾雨魔理沙 <[email protected]> * Refactor compiler * Fix * Fix * Fix in benchmark * Fix * Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final PR for the runtime series, adds the VM compiler and its associated test cases.
Blocked on: #2889.