[Relay][Runtime] Implementation of Relay VM #2889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
requested changes
Mar 25, 2019
tests/python/relay/model_zoo_data/lstm_i128_h128-symbol.json.data
Outdated
Show resolved
Hide resolved
wweic
requested changes
Mar 25, 2019
jroesch
force-pushed
the
relay-rts
branch
2 times, most recently
from
1d28c24 to
02c0823
Compare
jroesch
force-pushed
the
relay-rts
branch
2 times, most recently
from
b4f7b73 to
59181eb
Compare
jroesch
commented
Apr 16, 2019
jroesch
commented
Apr 16, 2019
jroesch
commented
Apr 16, 2019
jroesch
commented
Apr 16, 2019
jroesch
commented
Apr 16, 2019
jroesch
commented
Apr 16, 2019
jroesch
commented
Apr 16, 2019
jroesch
commented
Apr 16, 2019
jroesch
commented
Apr 16, 2019
jroesch
commented
Apr 16, 2019
jroesch
commented
Apr 16, 2019
jroesch
commented
Apr 16, 2019
|
I had do a quick review and will do a more through one later. |
zhiics
reviewed
Apr 17, 2019
wweic
reviewed
Apr 17, 2019
|
reviewers, please https://docs.tvm.ai/contribute/code_review.html#approve-and-request-changes-explicitly @vinx13 @sgrechanik-h @junrushao1994 @kazum @hlu1 please also help review if you have time |
wweic
requested changes
Apr 18, 2019
MarisaKirisame
approved these changes
Apr 18, 2019
weberlo
reviewed
Apr 18, 2019
Co-Authored-By: jroesch <[email protected]>
Co-Authored-By: jroesch <[email protected]>
Co-Authored-By: jroesch <[email protected]>
Co-Authored-By: jroesch <[email protected]>
Co-Authored-By: jroesch <[email protected]>
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
May 13, 2019
* Implement the virtual machine Co-Authored-By: wweic <[email protected]> * Fix rebase build issues * Reorganize vm.py and fix allocator bug * Remove compiler * Remove tests * Remove backend/vm/vm.cc too * Fix docs * Fix doc * Fix doc * Add vm docs * Remove change to dead_code.cc * Remove Relay logging * Remove reduce * Update include/tvm/runtime/vm.h Co-Authored-By: jroesch <[email protected]> * Reformat * Update include/tvm/runtime/vm.h Co-Authored-By: jroesch <[email protected]> * Address feedback * Update include/tvm/runtime/vm.h Co-Authored-By: jroesch <[email protected]> * Apply suggestions from code review Co-Authored-By: jroesch <[email protected]> * Fix a couple outstanding comments * Last couple comments * Update include/tvm/runtime/vm.h Co-Authored-By: jroesch <[email protected]> * Address code review feedback * Fix final comment * Address comments * Error reporting and example * add Const * Explicitly delete copy assignment operator * Fix rebase * Pass 3rd arg to fusion
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 13, 2019
* Implement the virtual machine Co-Authored-By: wweic <[email protected]> * Fix rebase build issues * Reorganize vm.py and fix allocator bug * Remove compiler * Remove tests * Remove backend/vm/vm.cc too * Fix docs * Fix doc * Fix doc * Add vm docs * Remove change to dead_code.cc * Remove Relay logging * Remove reduce * Update include/tvm/runtime/vm.h Co-Authored-By: jroesch <[email protected]> * Reformat * Update include/tvm/runtime/vm.h Co-Authored-By: jroesch <[email protected]> * Address feedback * Update include/tvm/runtime/vm.h Co-Authored-By: jroesch <[email protected]> * Apply suggestions from code review Co-Authored-By: jroesch <[email protected]> * Fix a couple outstanding comments * Last couple comments * Update include/tvm/runtime/vm.h Co-Authored-By: jroesch <[email protected]> * Address code review feedback * Fix final comment * Address comments * Error reporting and example * add Const * Explicitly delete copy assignment operator * Fix rebase * Pass 3rd arg to fusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This represents the culmination of #2810.
The final version of the VM adapts ideas from both proposals into a unified design.
This PR is work from @wweic @icemelon9 @zhiics and I.
Review please:
cc @joshpoll @weberlo @MarisaKirisame @slyubomirsky @tqchen @nhynes @ZihengJiang @junrushao1994