KAFKA-19544: Improve MetadataVersion.fromVersionString() to take an enableUnstableFeature flag
#20248
Conversation
… enableUnstableFeature flag
github-actions
bot
added
triage
| @@ -315,11 +305,9 @@ private static void handleUpgradeOrDowngrade(String op, Namespace namespace, Adm | |||
| if (metadata != null) { | |||
| System.out.println(" `metadata` flag is deprecated and may be removed in a future release."); | |||
| try { | |||
| metadataVersion = MetadataVersion.fromVersionString(metadata); | |||
| metadataVersion = MetadataVersion.fromVersionString(metadata, false); | |||
There was a problem hiding this comment.
we should allow users to update the unstable feature using feature tool, right?
There was a problem hiding this comment.
This refers to the original implementation. When originally throwing an exception using MetadataVersion.latestProduction(), the parameter passed to fromVersionString() was false. When originally throwing an exception using MetadataVersion.latestTesting(), the parameter passed to fromVersionString() was true.
There was a problem hiding this comment.
Yes, it remains consistent with the original implementation. However, it also introduces a new restriction
} else if (!unstableFeatureVersionsEnabled && !metadataVersion.isProduction()) {
throw new IllegalArgumentException(errorMsg);For example, users may download the trunk source code to test an upgrade with an older version of Kafka, and this new restriction could prevent them from upgrading to a non-production MV. Shouldn't it?
Improve
MetadataVersion.fromVersionString()to take anenableUnstableFeatureflag,and enable
FeatureCommandandStorageToolto leverage the exception message fromfromVersionString.