MINOR: Fix compiler warnings and add @nowarn for the unfixed ones #8490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also upgrade to scala-collection-compat 2.1.5 as it introduces the @nowarn annotation. Scala 2.13.2 (soon to be released) suppresses warnings with this annotation.
|
Looks like the annotation is somehow not in the binary. I added a comment to the upstream ticket: scala/scala-collection-compat#312 (comment) Edit: fixed in scala-collection-compat 2.1.6. |
3 tasks
|
Looks like this annotation is not present in the Scala 2.13 version of this library. So we need to wait for Scala 2.13.2 to be released before we can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also upgrade to scala-collection-compat 2.1.6 as it introduces the
@nowarn annotation.
Scala 2.13.2 (soon to be released) suppresses warnings with this
annotation.
While at it, also update scala-java8-compat to 0.9.1.
Committer Checklist (excluded from commit message)