[K8S][HELM] Add configuration support for multiple frontends to helm chart #4147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
cc @runzhliu |
pan3793
reviewed
Jan 13, 2023
Member
pan3793
left a comment
pan3793
left a comment
There was a problem hiding this comment.
Thanks for great work, let some comments
Contributor
|
LGTM. |
Contributor
|
Looks like unittest or e2e test for Kyuubi Helm Chart is needed. @cfmcgrady @pan3793 |
dnskr
force-pushed
the
helm_frontend_configs
branch
from
8ddef6a to
65e1f59
Compare
dnskr
force-pushed
the
helm_frontend_configs
branch
from
481fe00 to
ab10dd1
Compare
pan3793
approved these changes
Feb 3, 2023
Member
|
Thanks, merged to master |
4 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The changes allow to configure multiple frontends in the helm chart.
Notes:
server.confDirrenamed tokyuubiConfDirserver.confrenamed tokyuubiConflivenessProbeandreadinessProbechanged to executebin/kyuubi statuswhich actually printsKyuubi is not running. The issue needs to be reviewed. AlsolivenessProbeandreadinessProbeshould be revisited in the next PR.How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request