[MASFRES-30] Exclude all CI configuration files

[jira-importer]

Michael Osipov opened MASFRES-30 and commented

Exclude:

• .github
• Jenkinsfile
• .asf.yaml
• .travis.yml
• deploySite.sh

---

Affects: apache-source-release-assembly-descriptor-1.0.6

Issue Links:

• MASFRES-20 switch Apache Resource Bundles from svn to Git
  ("depends upon")

Remote Links:

• GitHub Pull Request #5
  
• GitHub Pull Request #6
  

[jira-importer]

Michael Osipov commented

Fixed with r1876681.

[jira-importer]

Herve Boutemy commented

but not mirrored to Git https://github.com/apache/maven-resources

someone will have to work on migrating these resources to Git, or we're going to have issues knowing what is where https://cwiki.apache.org/confluence/display/MAVEN/Git+Migration

[jira-importer]

Herve Boutemy commented

I'm not convinced removing these files make sense: why?

[jira-importer]

Michael Osipov commented

They are useless in the source release bundles. They have only a meaning when contained in the repo available at ASF or GH. After a release they cannot be used to execute then tests since that would again require an SCM, etc.

[jira-importer]

Herve Boutemy commented

sure
please re-commit to Git https://github.com/apache/maven-apache-resources/ , now that everything is migrated, then we can do a release

[jira-importer]

Michael Osipov commented

Fixed with d5657cda2186da47153db96b674154c4b8218054.

[jira-importer]

Christopher Tubbs commented

A related issue: I noticed that SCM files like .gitignore are being included, but the main .git directory is not. Is this resource bundle supposed to be excluding those, or is maven-assembly-plugin itself supposed to ignore those by default? I'm asking because I noticed that these .gitignore files seem to be included lately, but I think it wasn't too long ago that these were excluded. I'm not sure if this component should exclude them or if that's a MASSEMBLY issue.

[jira-importer]

Michael Osipov commented

Both are fundamentally different: .git is a meta dir handling the repo, .gitattributes is a versioned file. You needmto exclude it like any other file. Just like .gitignore.

[jira-importer]

Christopher Tubbs commented

Michael Osipov I think I would argue that the .gitignore and .gitattributes files are also meta files for git, and also the .git file when in a git worktree. All those only have meaning/utility inside a git repository. Inside a source artifact with the .git directory removed and the git aspect removed, they have no value, similar to the IDE files.

[jira-importer]

Michael Osipov commented

I disagree, there are plugins which read those files and continue processing, .e.g, RAT plugin. Very much like .editorconfig.

[jira-importer]

Christopher Tubbs commented

Michael Osipov I'm sure there are plugins that process .git/config as well. I'm not sure that makes much of a difference. For me, the question about whether it makes sense to exclude them is basically: do I want these in an ASF source-release tarball? And the answer is: no, because they only matter in the git repo, not the source-release tarball. If they aren't excluded by default... how do I exclude them from the source-release tarball assembly, then?

[jira-importer]

Resolve #36