[MDEP-844] Go Offline doesn't honor exclusions.

[jira-importer]

John Patrick opened MDEP-844 and commented

Using the example below;

 

<dependencyMangement>
  <dependencies>
    <dependency>
      <groupId>org.apache.commons</groupId>
      <artifactId>commons-configuration2</artifactId>
      <version>2.8.0</version>
      <exclusions>
        <exclusion>
          <groupId>org.apache.commons</groupId>
          <artifactId>commons-vfs2</artifactId>
        </exclusion>
      </exclusions>
    </dependency>
  </dependencies>
</dependencyMangement>

 

When executing ./mvnw org.apache.maven.plugins:maven-dependency-plugin:3.5.0:go-offline -Dmaven.repo.local=new-dir.
I wouldn't expect commons-vfs2 to be attempted to be downloads or appear in new-dir.

---

Affects: 3.5.0

2 votes, 4 watchers

[jira-importer]

Michael Osipov commented

Interesting...but does it hurt?

[jira-importer]

John Patrick commented

Yes if you have a Nexus Firewall blocking an optional dependency, and they won't approve it. So it go-offline fails due to missing dependency that is excluded.

[jira-importer]

Michael Osipov commented

Optional? That is would not appear on the classpath, no? <optional>true</optional>.

[jira-importer]

Elliotte Rusty Harold commented

Likely related to, though not quite the same as, MDEP-568:

dependency:go-offline -DexcludeGroupIds=xxxx still try to resolve artifacts in the excluded group xxxx

[slawekjaranowski]

should be resolved by:

• Use Resolver API in go-offline for dependencies resolving #1533