[MJAVADOC-639] aggregate should use all requires static from maven modules

[jira-importer]

Olivier Lamy opened MJAVADOC-639 and commented

---

Attachments:

• MJAVADOC-639_aggr_static_modulepath.zip (14.53 kB)
• MJAVADOC-639_requires_ignored.zip (12.40 kB)

Remote Links:

• GitHub Pull Request #38
  

[jira-importer]

Olivier Lamy commented

Robert Scholte your it works because the requires static is a module part of the reactor. but for a dependency it doesn't :) 

see attached IT.

[jira-importer]

Olivier Lamy commented

changes ready in branch MJAVADOC-639 for:

• https://github.com/codehaus-plexus/plexus-languages.git

• https://github.com/apache/maven-javadoc-plugin.git

 

 

[jira-importer]

Robert Scholte commented

Regarding plexus-java, the request.isIncludeAdditionalModulesStatic() has effect on all modules, so let's simplify that method to request.isIncludeStatic() (and related stuff)
I don't see any related changes in the maven-javadoc-plugin branch

[jira-importer]

Olivier Lamy commented

Robert Scholte arghh my bad :) look at 9eef0fa

 

[jira-importer]

Robert Scholte commented

I'm very happy to see that in the end it is just this one-liner to fix it: request.setIncludeAdditionalModulesStatic( isAggregator() );
Let's simplify this methodname and we're good to go.

[jira-importer]

Olivier Lamy commented

Robert Scholte yes only one line.. AbstractJavadocMojo is such a big mess better to not add more :)