Use consistently the encoding expected by Javadoc for reading and writing of data

[fridrich]

Following this checklist to help us incorporate your
contribution quickly and easily:

• Your pull request should address just one issue, without pulling in other changes.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Each commit in the pull request should have a meaningful subject line and body.
  Note that commits might be squashed by a maintainer on merge.
• Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
  This may not always be possible but is a best-practice.
• Run mvn verify to make sure basic checks pass.
  A more thorough check will be performed on your pull request automatically.
• You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
• In any other case, please file an Apache Individual Contributor License Agreement.

[fridrich]

Would be nice to run workflows on this just to know whether it solves what it should solve

[fridrich]

I did not give much thought to the method names or pretty javadoc description. Once we are sure something like this works, I will beautify.

[fridrich]

See: #1274

[fridrich]

@gnodet what do you think about this one?

[gnodet]

@gnodet what do you think about this one?

I haven't looked if we cover all the needed calls to files being read or written, but this looks good at first glance.

[fridrich]

what would be the best name for this method? the getDataCharset was nice for the StaleHelper, but more generic would be something like getSystemEncoding or even more accurate getEncodingToUse... I have no idea :/

[fridrich]

@gnodet what do you think about this one?

I haven't looked if we cover all the needed calls to files being read or written, but this looks good at first glance.

I grepped UTF_8 and then the files that had it, I checked the different calls. If this one passes all the ITs on all platforms, I will have to beautify it and will go through all of the source files looking for usual suspects.

[fridrich]

the version 25 in the matrix brings a dilemma. Groovy 5+ supports JDK11+ until 25, thus does not support JDK8. Groovy 4.x supports JDK8, but does not support JDK25.

[fridrich]

@gnodet there are two occurrences of StandardCharsets.UTF_8 in JavadocUtil.java, but they have nothing to do with the filesystem encoding. In both cases, it is the encoding of maven invokerLog used to convert the byte[] resulting from reading it by Files.readAllBytes into a String. They should be left as they are IMHO.

[fridrich]

@gnodet there are two occurrences of StandardCharsets.UTF_8 in JavadocUtil.java, but they have nothing to do with the filesystem encoding. In both cases, it is the encoding of maven invokerLog used to convert the byte[] resulting from reading it by Files.readAllBytes into a String. They should be left as they are IMHO.

And I was overkeen in one place in AbstractJavadocMojo.java where the situation is the same

[fridrich]

OK, I cleaned all the stuff and this PR is not WIP any more. I officially request review of this PR. @gnodet