Skip to content

Conversation

@Pankraz76
Copy link

is the new feature anything good for maven?

related to:

@Pankraz76 Pankraz76 marked this pull request as ready for review September 26, 2025 12:08
@Pankraz76
Copy link
Author

Pankraz76 commented Sep 28, 2025

Thanks

@Pankraz76
Copy link
Author

you have closed this without any comment i remember.

what is going on here?

Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use spotless to reformat code or fix things. Afaik, we don't have any rule that would not automatically be fixed by spotless. We already have a checkstyle rule to forbid wildcard imports, so not sure what the benefit would be with this PR.

I'd be happy if we could have an automatic transformation of wildcard imports to individual imports, but unless that's possible, I'm against duplicating the checks for no added value.

@Pankraz76
Copy link
Author

Nice, yes — then it’s just the second layer. Maybe automation will become a thing later on. For now, it’s currently not fixable, that’s correct. So in the end, it wouldn’t do any harm, as it’s similar to the existing solution — assuming this might increase coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants