[MPMD-403] Standalone :pmd goal cannot be executed for 'skin cannot be null'

[jira-importer]

Piotr Zygielo opened MPMD-403 and commented

For example with project that has no m-pmd-p configured:

$ git init maven-jar-plugin
$ cd maven-jar-plugin
$ git remote add origin https://github.com/apache/maven-jar-plugin
$ git fetch origin --depth=1 be27b5f35a8ca911a459d992c9c8f106084bf525
$ git checkout be27b5f35a8ca911a459d992c9c8f106084bf525

previously (3.24.0):

$ mvn org.apache.maven.plugins:maven-pmd-plugin:3.24.0:pmd
...
[INFO] --- pmd:3.24.0:pmd (default-cli) @ maven-jar-plugin ---
[WARNING] Unable to locate Source XRef to link to - DISABLED
[INFO] PMD version: 7.3.0
[INFO] Rendering content with org.apache.maven.skins:maven-default-skin:jar:1.3 skin.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  7.372 s
[INFO] Finished at: 2024-09-07T15:04:57+02:00
[INFO] ------------------------------------------------------------------------

while now (3.25.0):

$ mvn org.apache.maven.plugins:maven-pmd-plugin:3.25.0:pmd
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  7.802 s
[INFO] Finished at: 2024-09-07T15:08:59+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.25.0:pmd (default-cli) on project maven-jar-plugin: Execution default-cli of goal org.apache.maven.plugins:maven-pmd-plugin:3.25.0:pmd failed: skin cannot be null -> [Help 1]

 

1. first bad commit: [c31b29af9835652db9ab0b9e919c8e14bc4efabf] [MPMD-389] Upgrade to Doxia 2.0.0 Milestone Stack

---

After checking site.xml there (m-jar-p), and adding <skin> it's fine to use 3.25.0.
Thus changing the type and priority.

Feel free to close as invalid. I'm sorry for the noise.

---

Affects: 3.25.0

Remote Links:

• Doxia PR #227 to expose no-op sink/format
  

[jira-importer]

Piotr Zygielo commented

(Repeated for visibiliy:) Feel free to close as invalid.

[jira-importer]

Piotr Zygielo commented

For completeness - with :pmd being reporting plugin, and with no goal (that I could find) to do non-reporting analysis to produce pmd.xml only, with reporting context (and checking for {}skin{}) being prepared early, I'm able to work around my original problem, by configuring doxia to use other than html format (and not fail for project with not updated {}site.xml{}).

[jira-importer]

Michael Osipov commented

I cannot reproduce:

D:\Entwicklung\Projekte> git clone https://github.com/apache/maven-jar-plugin.git
Cloning into 'maven-jar-plugin'...
remote: Enumerating objects: 4305, done.
remote: Counting objects: 100% (810/810), done.
remote: Compressing objects: 100% (384/384), done.
remote: Total 4305 (delta 356), reused 660 (delta 248), pack-reused 3495 (from 1)
Receiving objects: 100% (4305/4305), 577.84 KiB | 4.13 MiB/s, done.
Resolving deltas: 100% (1462/1462), done.
D:\Entwicklung\Projekte> cd .\maven-jar-plugin\
D:\Entwicklung\Projekte\maven-jar-plugin [master ≡]> D:\Entwicklung\Programme\apache-maven-3.9.9\bin\mvn.cmd org.apache.maven.plugins:maven-pmd-plugin:3.25.0:pmd -V
Apache Maven 3.9.9 (8e8579a9e76f7d015ee5ec7bfcdc97d260186937)
Maven home: D:\Entwicklung\Programme\apache-maven-3.9.9
Java version: 1.8.0_412, vendor: Temurin, runtime: C:\Program Files\Eclipse Adoptium\jdk-8.0.412.8-hotspot\jre
Default locale: de_DE, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
[INFO] Scanning for projects...
[INFO]
[INFO] -------------< org.apache.maven.plugins:maven-jar-plugin >--------------
[INFO] Building Apache Maven JAR Plugin 4.0.0-beta-2-SNAPSHOT
[INFO]   from pom.xml
[INFO] ----------------------------[ maven-plugin ]----------------------------
[INFO]
[INFO] --- pmd:3.25.0:pmd (default-cli) @ maven-jar-plugin ---
[WARNING] Unable to locate Source XRef to link to - DISABLED
[INFO] PMD version: 7.3.0
[WARNING] Site model of 'org.apache.maven.plugins:maven-jar-plugin:maven-plugin:4.0.0-beta-2-SNAPSHOT' for default locale is still using the old pre-version 2.0.0 model. You MUST migrate to the new model as soon as possible otherwise your build will break in the future!
[WARNING] Site model of 'org.apache.maven.plugins:maven-plugins:pom:42' for default locale is still using the old pre-version 2.0.0 model. You MUST migrate to the new model as soon as possible otherwise your build will break in the future!
[WARNING] Site model of 'org.apache.maven:maven-parent:pom:42' for default locale is still using the old pre-version 2.0.0 model. You MUST migrate to the new model as soon as possible otherwise your build will break in the future!
[INFO] Rendering content with org.apache.maven.skins:maven-fluido-skin:jar:1.11.2 skin
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  4.129 s
[INFO] Finished at: 2024-09-08T10:29:33+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.25.0:pmd (default-cli) on project maven-jar-plugin: An error has occurred in PMD report generation.: Failed to create context for skin: Cannot use skin: has [1.11.1,2.0.0-M1) Doxia Sitetools prerequisite, but current is 2.0.0-M19 -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

Will try Java 21, but highly doubt that that is the reason.

[jira-importer]

Michael Osipov commented

Same:

D:\Entwicklung\Projekte\maven-jar-plugin [master ≡]> D:\Entwicklung\Programme\apache-maven-3.9.9\bin\mvn.cmd org.apache.maven.plugins:maven-pmd-plugin:3.25.0:pmd -V
Apache Maven 3.9.9 (8e8579a9e76f7d015ee5ec7bfcdc97d260186937)
Maven home: D:\Entwicklung\Programme\apache-maven-3.9.9
Java version: 21.0.3, vendor: Eclipse Adoptium, runtime: C:\Program Files\Eclipse Adoptium\jdk-21.0.3.9-hotspot
Default locale: de_DE, platform encoding: UTF-8
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
[INFO] Scanning for projects...
[INFO]
[INFO] -------------< org.apache.maven.plugins:maven-jar-plugin >--------------
[INFO] Building Apache Maven JAR Plugin 4.0.0-beta-2-SNAPSHOT
[INFO]   from pom.xml
[INFO] ----------------------------[ maven-plugin ]----------------------------
[INFO]
[INFO] --- pmd:3.25.0:pmd (default-cli) @ maven-jar-plugin ---
[WARNING] Unable to locate Source XRef to link to - DISABLED
[INFO] PMD version: 7.3.0
[WARNING] Site model of 'org.apache.maven.plugins:maven-jar-plugin:maven-plugin:4.0.0-beta-2-SNAPSHOT' for default locale is still using the old pre-version 2.0.0 model. You MUST migrate to the new model as soon as possible otherwise your build will break in the future!
[WARNING] Site model of 'org.apache.maven.plugins:maven-plugins:pom:42' for default locale is still using the old pre-version 2.0.0 model. You MUST migrate to the new model as soon as possible otherwise your build will break in the future!
[WARNING] Site model of 'org.apache.maven:maven-parent:pom:42' for default locale is still using the old pre-version 2.0.0 model. You MUST migrate to the new model as soon as possible otherwise your build will break in the future!
[INFO] Rendering content with org.apache.maven.skins:maven-fluido-skin:jar:1.11.2 skin
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  4.309 s
[INFO] Finished at: 2024-09-08T10:31:20+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.25.0:pmd (default-cli) on project maven-jar-plugin: An error has occurred in PMD report generation.: Failed to create context for skin: Cannot use skin: has [1.11.1,2.0.0-M1) Doxia Sitetools prerequisite, but current is 2.0.0-M19 -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

Purge your local Maven repo and try again.

[jira-importer]

Piotr Zygielo commented

Michael Osipov: On empty repo and with everything re-fetched from central I'm getting the same failure as you, indeed.

(Still, setting output.format helps.)

[jira-importer]

Michael Osipov commented

So all is good and the failure is correct.

[jira-importer]

Piotr Zygielo commented

-Yes, it's the failure due to contents of the existing {}site.xml{}.-

[jira-importer]

Piotr Zygielo commented

So all is good and the failure is correct.

Everything is correct, only goal cannot be executed.

[jira-importer]

Michael Osipov commented

Yes, one needs to update the skin first then the rendering will work.

[jira-importer]

Piotr Zygielo commented

To clarify: Currently standalone :pmd does not work in 3.25.0, and there is no need to have issue for this in MPMD. Right?

[jira-importer]

Michael Osipov commented

If you mean the skin issue. No, no issue required because the behavior is expected. New Doxia stack needs updated skin.

[jira-importer]

Piotr Zygielo commented

Now, that you patiently repeated it, I can see that in m-jar-p (that I so fixated on for no reason truly), with the help of {}help:effective-pom{}, there is version.maven-fluido-skin defined indeed.
Thank you.

[jira-importer]

Michael Osipov commented

Very good.