Skip to content

Add missing equals and hashCode methods in modular Java path type. #11130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2025
Merged

Add missing equals and hashCode methods in modular Java path type. #11130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,25 @@ public String[] option(Iterable<? extends Path> paths) {
return format(moduleName, paths);
}

/**
* {@return a hash code value based on the raw type and module name}.
*/
@Override
public int hashCode() {
return rawType().hashCode() + 17 * moduleName.hashCode();
}

/**
* {@return whether the given object represents the same type of path as this object}.
*/
@Override
public boolean equals(Object obj) {
if (obj instanceof Modular m) {
return rawType() == m.rawType() && moduleName.equals(m.moduleName);
}
return false;
}

/**
* Returns the programmatic name of this path type, including the module to patch.
* For example, if this type was created by {@code JavaPathType.patchModule("foo.bar")},
Expand Down
Loading