-
Notifications
You must be signed in to change notification settings - Fork 42
[SPARK-53457] Expose fabric8 dependencies as api for downstream users #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jiangzho
wants to merge
3
commits into
apache:main
Choose a base branch
from
jiangzho:api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
<!-- | ||
Licensed to the Apache Software Foundation (ASF) under one | ||
or more contributor license agreements. See the NOTICE file | ||
distributed with this work for additional information | ||
regarding copyright ownership. The ASF licenses this file | ||
to you under the Apache License, Version 2.0 (the | ||
"License"); you may not use this file except in compliance | ||
with the License. You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, | ||
software distributed under the License is distributed on an | ||
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
KIND, either express or implied. See the License for the | ||
specific language governing permissions and limitations | ||
under the License. | ||
--> | ||
|
||
# Use Spark Operator API Library in Your Java Application | ||
|
||
In addition to direct YAML, you may also leverage our Java API library to create and manage Spark | ||
workloads. | ||
|
||
## Choosing the Right Dependency | ||
|
||
We publish two variants of this library: | ||
|
||
```groovy | ||
implementation("org.apache.spark:spark-operator-api") | ||
``` | ||
|
||
This library keeps your project free from a direct dependency on Fabric8 Kubernetes Client. It's | ||
recommended if you only interact with our API at the YAML/CRD level (e.g. generating manifests, | ||
using our higher-level abstractions). Use this if you don’t need direct access to Fabric8 model | ||
objects like PodTemplateSpec, Deployment, etc. | ||
|
||
If your application requires access on fabric8 models, it's recommended to use | ||
|
||
```groovy | ||
implementation("org.apache.spark:spark-operator-api-fabric8") | ||
``` | ||
|
||
This library publishes the same core library, with Fabric8 declared as an API dependency. This | ||
means Fabric8 model classes (Pod, PodTemplateSpec, Deployment, etc.) are available directly on | ||
your classpath when you depend on our library. It's recommended if you want to compose or extend | ||
Spark Operator API using Fabric8 types (for example, embedding a Fabric8 PodTemplateSpec into | ||
Spark Operator CRD). | ||
|
||
Do not depend on both `spark-operator-api` and `spark-operator-api-fabric8` at the same time. | ||
Choose one based on your use case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
plugins { | ||
id 'java-library' | ||
} | ||
|
||
dependencies { | ||
api project(":spark-operator-api") | ||
// fabric8 | ||
api(libs.kubernetes.client) { | ||
exclude group: 'com.squareup.okhttp3' | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please mention that Apache Spark community doesn't aim to provide a compatibility for this module in terms of
Semantic Versioning
. Every version can talk to the exactly same version'sSpark Operator
, @jiangzho .