fix review comments

iRakson · iRakson · commit ab27a0fc9b0f · 2020-02-19T11:13:11.000+05:30
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
@@ -2132,7 +2132,7 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
   test("SPARK-27619: when spark.sql.legacy.useHashOnMapType is true, hash can be used on Maptype") {
     Seq("hash", "xxhash64").foreach {
       case hashExpression =>
-        withSQLConf(SQLConf.LEGACY_USE_HASH_ON_MAPTYPE.key -> true.toString()) {
+        withSQLConf(SQLConf.LEGACY_USE_HASH_ON_MAPTYPE.key -> "true") {
           val df = spark.createDataset(Map() :: Nil)
           checkAnswer(df.selectExpr(s"$hashExpression(*)"), sql(s"SELECT $hashExpression(map())"))
         }

Original file line number	Diff line number	Diff line change
`@@ -2132,7 +2132,7 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark`
`2132`	`2132`	`test("SPARK-27619: when spark.sql.legacy.useHashOnMapType is true, hash can be used on Maptype") {`
`2133`	`2133`	`Seq("hash", "xxhash64").foreach {`
`2134`	`2134`	`case hashExpression =>`
`2135`		`- withSQLConf(SQLConf.LEGACY_USE_HASH_ON_MAPTYPE.key -> true.toString()) {`
	`2135`	`+ withSQLConf(SQLConf.LEGACY_USE_HASH_ON_MAPTYPE.key -> "true") {`
`2136`	`2136`	`val df = spark.createDataset(Map() :: Nil)`
`2137`	`2137`	`checkAnswer(df.selectExpr(s"$hashExpression(*)"), sql(s"SELECT $hashExpression(map())"))`
`2138`	`2138`	`}`