Skip to content

[SPARK-12234] [SparkR] Fix subset function error when only set select argument #10217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[SPARK-12234] [SparkR] Fix subset function error when only set select argument #10217

wants to merge 3 commits into from

Conversation

@yanboliang
Copy link
Contributor

Fix subset function error when only set select argument. Please refer to the JIRA about the error and how to reproduce it.

cc @sun-rui @felixcheung @shivaram

@yanboliang yanboliang changed the title [SPARK-12234] [SparkR] Fix subset error when only set select argument [SPARK-12234] [SparkR] Fix subset function error when only set select argument Dec 9, 2015
@SparkQA
Copy link

SparkQA commented Dec 9, 2015

Test build #47411 has finished for PR 10217 at commit 5c71cd3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Member

cool, looks good

felixcheung
felixcheung reviewed Dec 9, 2015
View reviewed changes
R/pkg/R/DataFrame.R
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best if we could add an example above

sun-rui
sun-rui reviewed Dec 9, 2015
View reviewed changes
R/pkg/R/DataFrame.R Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2-space ident

@sun-rui
Copy link
Contributor

sun-rui commented Dec 9, 2015

also could you state in the method description that subset parameter is optional?

@SparkQA
Copy link

SparkQA commented Dec 9, 2015

Test build #47417 has finished for PR 10217 at commit 92b1bd7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 9, 2015

Test build #47421 has finished for PR 10217 at commit acc8457.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sun-rui
Copy link
Contributor

sun-rui commented Dec 9, 2015

LGTM

@SparkQA
Copy link

SparkQA commented Dec 10, 2015

Test build #47519 has finished for PR 10217 at commit acc8457.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

LGTM. Thanks @yanboliang - Merging this

asfgit pushed a commit that referenced this pull request Dec 10, 2015
@yanboliang @shivaram
[SPARK-12234][SPARKR] Fix subset function error when only set `…
93ef246 
…``select``` argument

Fix ```subset``` function error when only set ```select``` argument. Please refer to the [JIRA](https://issues.apache.org/jira/browse/SPARK-12234) about the error and how to reproduce it.

cc sun-rui felixcheung shivaram

Author: Yanbo Liang <[email protected]>

Closes #10217 from yanboliang/spark-12234.

(cherry picked from commit d9d354e)
Signed-off-by: Shivaram Venkataraman <[email protected]>
@asfgit asfgit closed this in d9d354e Dec 10, 2015
@yanboliang yanboliang deleted the spark-12234 branch December 11, 2015 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yanboliang @SparkQA @felixcheung @sun-rui @shivaram