Skip to content

[SPARK-12242][SQL] Add DataFrame.transform method #10226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-12242][SQL] Add DataFrame.transform method #10226

wants to merge 1 commit into from

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Dec 9, 2015

No description provided.

rxin
rxin reviewed Dec 9, 2015
View reviewed changes
sql/core/src/main/scala/org/apache/spark/sql/Column.scala
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @marmbrus I changed it to a string literal. Otherwise it might be confusing to some users thinking the way to specify a numeric literal is also to wrap it in string.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

@marmbrus
Copy link
Contributor

marmbrus commented Dec 9, 2015

Should we add a test and a java version?

@SparkQA
Copy link

SparkQA commented Dec 10, 2015

Test build #2193 has finished for PR 10226 at commit a1fac56.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaIndexToStringExample\n

@SparkQA
Copy link

SparkQA commented Dec 10, 2015

Test build #2192 has finished for PR 10226 at commit a1fac56.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor Author

rxin commented Dec 10, 2015

I want to add Java API, but we need to decide first do we have an interface for DataFrame -> DataFrame, or just reuse the existing one. What do you think?

I'm going to merge this one first so at least the Scala one can show up in 1.6...

asfgit pushed a commit that referenced this pull request Dec 10, 2015
@rxin
[SPARK-12242][SQL] Add DataFrame.transform method
f939c71 
Author: Reynold Xin <[email protected]>

Closes #10226 from rxin/df-transform.

(cherry picked from commit 76540b6)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in 76540b6 Dec 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rxin @marmbrus @SparkQA