Skip to content

[SPARK-12215][ML][DOC] User guide section for KMeans in spark.ml #10244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[SPARK-12215][ML][DOC] User guide section for KMeans in spark.ml #10244

wants to merge 6 commits into from

Conversation

yu-iskw
Copy link
Contributor

@yu-iskw yu-iskw commented Dec 10, 2015

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Dec 10, 2015

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Dec 10, 2015

Test build #47485 has finished for PR 10244 at commit e8e9c14.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

jkbradley
jkbradley reviewed Dec 11, 2015
View reviewed changes
docs/ml-clustering.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no longer support for multiple parallel runs, at least for now.

Also, could you include the same links as in the text in mllib-clustering.md?

@jkbradley
Copy link
Member

Done with one pass.
Thanks, and sorry for making you wait!

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Dec 14, 2015

@jkbradley thank you for reviewing it. I modified some a few points. Can you review it again?

  • Include the import statments of JavaKMeansExample in the doc
  • Simplify KMeansExample code, accoding to BinarizerExample.scala]
  • Modify the description about KMeans in ml-clustering.md

@SparkQA
Copy link

SparkQA commented Dec 14, 2015

Test build #47644 has finished for PR 10244 at commit 3c1d982.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

jkbradley
jkbradley reviewed Dec 15, 2015
View reviewed changes
docs/ml-clustering.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the unused "Notes" column

@jkbradley
Copy link
Member

Thank you for the updates! I just had those 2 small comments.

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Dec 16, 2015

@jkbradley thank you so much for the review. I modified the 2 points.

@SparkQA
Copy link

SparkQA commented Dec 16, 2015

Test build #47778 has finished for PR 10244 at commit 2ed9b11.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

LGTM, merging with master and branch-1.6
Thanks for the PR!

asfgit pushed a commit that referenced this pull request Dec 16, 2015
@yu-iskw @jkbradley
[SPARK-12215][ML][DOC] User guide section for KMeans in spark.ml
16edd93 
cc jkbradley

Author: Yu ISHIKAWA <[email protected]>

Closes #10244 from yu-iskw/SPARK-12215.

(cherry picked from commit 26d70bd)
Signed-off-by: Joseph K. Bradley <[email protected]>
@asfgit asfgit closed this in 26d70bd Dec 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yu-iskw @SparkQA @jkbradley