Skip to content

Conversation

@jerryshao
Copy link
Contributor

With the merge of SPARK-8337, now the Python API has the same functionalities compared to Scala/Java, so here changing the description to make it more precise.

@zsxwing @tdas , please review, thanks a lot.

@SparkQA
Copy link

SparkQA commented Dec 10, 2015

Test build #47490 has finished for PR 10246 at commit 5c5cd95.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member

zsxwing commented Dec 10, 2015

LGTM

@zsxwing
Copy link
Member

zsxwing commented Dec 10, 2015

Thanks @jerryshao. Merging to master, 1.6, 1.5, 1.4.

asfgit pushed a commit that referenced this pull request Dec 10, 2015
… doc

With the merge of [SPARK-8337](https://issues.apache.org/jira/browse/SPARK-8337), now the Python API has the same functionalities compared to Scala/Java, so here changing the description to make it more precise.

zsxwing tdas , please review, thanks a lot.

Author: jerryshao <[email protected]>

Closes #10246 from jerryshao/direct-kafka-doc-update.

(cherry picked from commit 24d3357)
Signed-off-by: Shixiong Zhu <[email protected]>
asfgit pushed a commit that referenced this pull request Dec 10, 2015
… doc

With the merge of [SPARK-8337](https://issues.apache.org/jira/browse/SPARK-8337), now the Python API has the same functionalities compared to Scala/Java, so here changing the description to make it more precise.

zsxwing tdas , please review, thanks a lot.

Author: jerryshao <[email protected]>

Closes #10246 from jerryshao/direct-kafka-doc-update.

(cherry picked from commit 24d3357)
Signed-off-by: Shixiong Zhu <[email protected]>
asfgit pushed a commit that referenced this pull request Dec 10, 2015
… doc

With the merge of [SPARK-8337](https://issues.apache.org/jira/browse/SPARK-8337), now the Python API has the same functionalities compared to Scala/Java, so here changing the description to make it more precise.

zsxwing tdas , please review, thanks a lot.

Author: jerryshao <[email protected]>

Closes #10246 from jerryshao/direct-kafka-doc-update.

(cherry picked from commit 24d3357)
Signed-off-by: Shixiong Zhu <[email protected]>
@asfgit asfgit closed this in 24d3357 Dec 10, 2015
@jerryshao
Copy link
Contributor Author

Hi @zsxwing, one of the feature "message handler" is only supported in 1.6. So maybe better not merge back to the previous version :).

@zsxwing
Copy link
Member

zsxwing commented Dec 10, 2015

Hi @zsxwing, one of the feature "message handler" is only supported in 1.6. So maybe better not merge back to the previous version :).

Is message handler mentioned in the doc? I cannot find it.

@jerryshao
Copy link
Contributor Author

No, it is not mentioned in the doc. What I mean is that for previous version, Python api still miss this piece of functionality, so correcting this description in the previous version is not exactly correct.

@zsxwing
Copy link
Member

zsxwing commented Dec 11, 2015

But it will be confusing if we say in Spark 1.4 for the Python API in the doc, but it doesn't in docs for 1.4 and 1.5.

We don't mention if we support a custom message handler in the doc. Even if Python api didn't support the message handler in 1.4 and 1.5, we can still say Python api supports the Kafka direct stream. Right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants