[Streaming][Minor] Fix typo in function name of StateImpl #10305
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #47723 has finished for PR 10305 at commit
|
|
lgtm (also someone needs to find a way to get rid of 3ourroom's junk comments). |
|
Thanks @holdenk . Not sure why there's so many junk comments, is it also existed in other PRs? |
|
Yes, quite a few actually. |
|
(Already reported this user to Github; others can do the same) |
|
LGTM |
|
Merging to master and 1.6. Thanks @jerryshao |
asfgit
pushed a commit
that referenced
this pull request
Dec 15, 2015
cc\ tdas zsxwing , please review. Thanks a lot. Author: jerryshao <[email protected]> Closes #10305 from jerryshao/fix-typo-state-impl. (cherry picked from commit bc1ff9f) Signed-off-by: Shixiong Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc\ @tdas @zsxwing , please review. Thanks a lot.