[SPARK-12368] [ML] [DOC] Better doc for the binary classification evaluator' metricName #10328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #47816 has finished for PR 10328 at commit
|
Contributor
Author
Contributor
Author
|
Cc @jkbradley |
Member
There was a problem hiding this comment.
Why is this diff here? Is there an odd character on this line?
Contributor
Author
There was a problem hiding this comment.
There were no newline chars at the end of the file and vim added one, I can remove it if it's an issue.
Member
There was a problem hiding this comment.
Oh OK, then no, you were correct
Member
|
@BenFradet Thank you for pinging again! It looks fine except for that odd diff line. |
Member
|
LGTM pending tests |
|
Test build #2339 has finished for PR 10328 at commit
|
Member
|
Merging with master Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the BinaryClassificationEvaluator, the scaladoc doesn't mention that "areaUnderPR" is supported, only that the default is "areadUnderROC".
Also, in the documentation, it is said that:
"The default metric used to choose the best ParamMap can be overriden by the setMetric method in each of these evaluators."
However, the method is called setMetricName.
This PR aims to fix both issues.