Skip to content

Conversation

marmbrus
Copy link
Contributor

No description provided.

@marmbrus
Copy link
Contributor Author

@liancheng, please take a look.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15740/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't invalidate cached table content here. Maybe we should add a link to the corresponding JIRA ticket to remind that.

@liancheng
Copy link
Contributor

LGTM :)

@asfgit asfgit closed this in 13f8cfd Jun 13, 2014
asfgit pushed a commit that referenced this pull request Jun 13, 2014
Author: Michael Armbrust <[email protected]>

Closes #1072 from marmbrus/cachedStars and squashes the following commits:

8757c8e [Michael Armbrust] Use planner for in-memory scans.

(cherry picked from commit 13f8cfd)
Signed-off-by: Michael Armbrust <[email protected]>
@tgravescs
Copy link
Contributor

@marmbrus @liancheng I think this broke branch-1.0 from building:

Error I am seeing:
[INFO] Compiling 5 Scala sources to/sql/core/target/scala-2.10/classes...
[ERROR] /sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala:173: too many arguments for method pruneFilterProject: (projectList: Seq[org.apache.spark.sql.catalyst.expressions.NamedExpression], filterPredicates: Seq[org.apache.spark.sql.catalyst.expressions.Expression], scanBuilder: Seq[org.apache.spark.sql.catalyst.expressions.Attribute] => org.apache.spark.sql.execution.SparkPlan)org.apache.spark.sql.execution.SparkPlan
[ERROR] pruneFilterProject(

@liancheng
Copy link
Contributor

@tgravescs @marmbrus I believe the reason of the compilation failure is that PR #863 was not merged into branch-1.0. That PR fixes a Parquet related bug and should be merged into branch-1.0. I'll try locally to see whether we can get it merged now, or I'll try to rebase that PR branch.

@marmbrus
Copy link
Contributor Author

Thanks for pointing this out @tgravescs.

@liancheng We should probably just fully update branch-1.0 with master as far as Spark SQL goes. We avoiding merging a few patches right near the 1.0 release, but there is no reason to keep them out of 1.0.1.

@liancheng
Copy link
Contributor

@marmbrus Just realized that the Parquet filter predicate pushdown optimization was also not merged. So I'd suggest we either merge both #511 and #863, or submit another PR for branch-1.0 to remove the prunePushDownFilters parameter and related logic and make branch-10 compilable.

@marmbrus
Copy link
Contributor Author

Here's a PR to bring 1.0 back in line with master: #1078

aarondav pushed a commit to aarondav/spark that referenced this pull request Jun 16, 2014
Author: Michael Armbrust <[email protected]>

Closes apache#1072 from marmbrus/cachedStars and squashes the following commits:

8757c8e [Michael Armbrust] Use planner for in-memory scans.

Conflicts:
	sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala
pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
Author: Michael Armbrust <[email protected]>

Closes apache#1072 from marmbrus/cachedStars and squashes the following commits:

8757c8e [Michael Armbrust] Use planner for in-memory scans.
@marmbrus marmbrus deleted the cachedStars branch July 8, 2014 22:49
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
Author: Michael Armbrust <[email protected]>

Closes apache#1072 from marmbrus/cachedStars and squashes the following commits:

8757c8e [Michael Armbrust] Use planner for in-memory scans.
wangyum pushed a commit that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants