[SPARK-13444] [MLlib] QuantileDiscretizer chooses bad splits on large DataFrames #11377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@oliverpierson When you create the PR, please choose branch-1.6 instead of master and put `[Branch-1.6] in the PR title. I think you need to close this one and create a new PR. |
|
Thanks @mengxr for helping fix this while I was away. Yes it looks good excepting that this needs to be vs branch-1.6 so we can test it with Jenkins explicitly. Thanks @oliverpierson |
|
No worries. I'll close and open a new one today. Would it make things easier if I rebase off of branch-1.6 before creating the new PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixes a bug in QuantileDiscretizer that results in the wrong number of bins for datasets larger than 10K rows and adds regression test. This PR corrects an issue with PR #11319.
How was this patch tested?
Manual tests and test-only QuantileDiscretizerSuite