[SPARK-13599] [BUILD] remove transitive groovy dependencies from spark-hive and spark-hiveserver (branch 1.6) #11473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #52327 has finished for PR 11473 at commit
|
|
As I asked in #11449 -- what's the reason to justify backporting this? Usually we don't do dependency changes in a maintenance release. |
|
Can you update the pull request description? The current one isn't great as is. |
steveloughran
changed the title
steveloughran
changed the title
|
@steveloughran if you'll update this to match #11449 (it has to have dependncy files update to pass) I'll merge |
|
will do |
|
Test build #52554 has finished for PR 11473 at commit
|
|
OK it's merged. You can close this PR manually now. |
asfgit
pushed a commit
that referenced
this pull request
Mar 7, 2016
…-hive and spark-hiveserver (branch 1.6) ## What changes were proposed in this pull request? This is just the patch of #11449 cherry picked to branch-1.6; the enforcer and dep/ diffs are cut Modifies the dependency declarations of the all the hive artifacts, to explicitly exclude the groovy-all JAR. This stops the groovy classes *and everything else in that uber-JAR* from getting into spark-assembly JAR. ## How was this patch tested? 1. Pre-patch build was made: `mvn clean install -Pyarn,hive,hive-thriftserver` 1. spark-assembly expanded, observed to have the org.codehaus.groovy packages and JARs 1. A maven dependency tree was created `mvn dependency:tree -Pyarn,hive,hive-thriftserver -Dverbose > target/dependencies.txt` 1. This text file examined to confirm that groovy was being imported as a dependency of `org.spark-project.hive` 1. Patch applied 1. Repeated step1: clean build of project with ` -Pyarn,hive,hive-thriftserver` set 1. Examined created spark-assembly, verified no org.codehaus packages 1. Verified that the maven dependency tree no longer references groovy The `master` version updates the dependency files and an enforcer rule to keep groovy out; this patch strips it out. Author: Steve Loughran <[email protected]> Closes #11473 from steveloughran/fixes/SPARK-13599-groovy+branch-1.6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is just the patch of #11449 cherry picked to branch-1.6; the enforcer and dep/ diffs are cut
Modifies the dependency declarations of the all the hive artifacts, to explicitly exclude the groovy-all JAR.
This stops the groovy classes and everything else in that uber-JAR from getting into spark-assembly JAR.
How was this patch tested?
mvn clean install -Pyarn,hive,hive-thriftservermvn dependency:tree -Pyarn,hive,hive-thriftserver -Dverbose > target/dependencies.txtorg.spark-project.hive-Pyarn,hive,hive-thriftserversetThe
masterversion updates the dependency files and an enforcer rule to keep groovy out; this patch strips it out.