[SPARK-14016][SQL] Support high-precision decimals in vectorized parquet reader #11869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @nongli |
Contributor
|
LGTM |
|
Test build #53725 has finished for PR 11869 at commit
|
Contributor
|
Thanks! Merging to master. |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
…uet reader ## What changes were proposed in this pull request? This patch adds support for reading `DecimalTypes` with high (> 18) precision in `VectorizedColumnReader` ## How was this patch tested? 1. `VectorizedColumnReader` initially had a gating condition on `primitiveType.getDecimalMetadata().getPrecision() > Decimal.MAX_LONG_DIGITS()` that made us fall back on parquet-mr for handling high-precision decimals. This condition is now removed. 2. In particular, the `ParquetHadoopFsRelationSuite` (that tests for all supported hive types -- including `DecimalType(25, 5)`) fails when the gating condition is removed (apache#11808) and should now pass with this change. Author: Sameer Agarwal <[email protected]> Closes apache#11869 from sameeragarwal/bigdecimal-parquet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch adds support for reading
DecimalTypeswith high (> 18) precision inVectorizedColumnReaderHow was this patch tested?
VectorizedColumnReaderinitially had a gating condition onprimitiveType.getDecimalMetadata().getPrecision() > Decimal.MAX_LONG_DIGITS()that made us fall back on parquet-mr for handling high-precision decimals. This condition is now removed.ParquetHadoopFsRelationSuite(that tests for all supported hive types -- includingDecimalType(25, 5)) fails when the gating condition is removed ([WIP][SPARK-13994][SQL] Investigate types not supported by vectorized parquet reader #11808) and should now pass with this change.