-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-15574][ML][PySpark] Python meta-algorithms in Scala #13794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #61127 has finished for PR 13794 at commit
|
|
test it please |
|
Test build #61129 has finished for PR 13794 at commit
|
|
test it please |
|
Test build #61133 has finished for PR 13794 at commit
|
|
retest this please |
|
Test build #61197 has finished for PR 13794 at commit
|
|
@jkbradley Update: Now I've added the PythonEstimator and PythonModel. For PythonEvaluator, it's better to commit in along with changes of CrossValidator. It's ready to review. |
|
@yinxusen - is this something you are still interested in? If so updating it to master would be good as well as making sure the unit tests pass in jenkins (a lot of reviwers just skip PRs which are failing tests). Although this is also pretty big so it might make sense to check with @jkbradley that this is something he is still interested in as well before you spend your time on it. |
|
Thanks @holdenk Yes, I am still interested in this. @jkbradley Do we still need the PR to support meta-algorithms in PySpark? |
|
@yinxusen Hi, are you still working on this? |
|
@yinxusen Thanks for this PR! I still think this seems like a very cool feature, but I've become less convinced that it's worth the engineering and maintenance effort. The alternative to this feature is to have meta-algorithms all implemented in Python as well as Scala. Since there are not many such meta-algorithms (4 currently), I think that sounds easier than implementing something like this. That's my current opinion, at least, especially since I have not seen a lot of demand for more meta-algorithms in MLlib. |
|
+1 @jkbradley For now it is better to keep the current implementation for the 4 meta-algo in pyspark. |
|
cc @srowen Can you help close this ? We won't need this feature for now. |
What changes were proposed in this pull request?
How was this patch tested?
Test with Python unit test and doc test.