[SPARK-18063][SQL] Failed to infer constraints over multiple aliases #15597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #67379 has finished for PR 15597 at commit
|
|
Test build #67433 has finished for PR 15597 at commit
|
sameeragarwal
suggested changes
Oct 24, 2016
| */ | ||
| protected def getAliasedConstraints(projectList: Seq[NamedExpression]): Set[Expression] = { | ||
| projectList.flatMap { | ||
| var aliasedConstraints = child.constraints.toSet |
There was a problem hiding this comment.
Remove toSet (ExpressionSet should support all these operations)
There was a problem hiding this comment.
I transformed child.constraints to Set[Expression] as we need to apply ++= operator on it.
| case _ => // Don't change. | ||
| } | ||
|
|
||
| aliasedConstraints |
There was a problem hiding this comment.
This should really return aliasedConstraints -- child.constraints. Perhaps rename aliasedConstraints to allConstraints and then return allConstraints -- child.constraints?
|
@sameeragarwal I've addressed your comments! Thank you! |
|
Test build #67504 has finished for PR 15597 at commit
|
|
LGTM, thanks! |
|
Just to be extra safe, it'd be great to re-run the test suite on this once #15319 is merged. |
|
retest this please |
|
Test build #67583 has finished for PR 15597 at commit
|
|
Merging this in master/branch-2.0. |
asfgit
pushed a commit
that referenced
this pull request
Oct 26, 2016
## What changes were proposed in this pull request?
The `UnaryNode.getAliasedConstraints` function fails to replace all expressions by their alias where constraints contains more than one expression to be replaced.
For example:
```
val tr = LocalRelation('a.int, 'b.string, 'c.int)
val multiAlias = tr.where('a === 'c + 10).select('a.as('x), 'c.as('y))
multiAlias.analyze.constraints
```
currently outputs:
```
ExpressionSet(Seq(
IsNotNull(resolveColumn(multiAlias.analyze, "x")),
IsNotNull(resolveColumn(multiAlias.analyze, "y"))
)
```
The constraint `resolveColumn(multiAlias.analyze, "x") === resolveColumn(multiAlias.analyze, "y") + 10)` is missing.
## How was this patch tested?
Add new test cases in `ConstraintPropagationSuite`.
Author: jiangxingbo <[email protected]>
Closes #15597 from jiangxb1987/alias-constraints.
(cherry picked from commit fa7d9d7)
Signed-off-by: Reynold Xin <[email protected]>
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Nov 1, 2016
## What changes were proposed in this pull request?
The `UnaryNode.getAliasedConstraints` function fails to replace all expressions by their alias where constraints contains more than one expression to be replaced.
For example:
```
val tr = LocalRelation('a.int, 'b.string, 'c.int)
val multiAlias = tr.where('a === 'c + 10).select('a.as('x), 'c.as('y))
multiAlias.analyze.constraints
```
currently outputs:
```
ExpressionSet(Seq(
IsNotNull(resolveColumn(multiAlias.analyze, "x")),
IsNotNull(resolveColumn(multiAlias.analyze, "y"))
)
```
The constraint `resolveColumn(multiAlias.analyze, "x") === resolveColumn(multiAlias.analyze, "y") + 10)` is missing.
## How was this patch tested?
Add new test cases in `ConstraintPropagationSuite`.
Author: jiangxingbo <[email protected]>
Closes apache#15597 from jiangxb1987/alias-constraints.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request?
The `UnaryNode.getAliasedConstraints` function fails to replace all expressions by their alias where constraints contains more than one expression to be replaced.
For example:
```
val tr = LocalRelation('a.int, 'b.string, 'c.int)
val multiAlias = tr.where('a === 'c + 10).select('a.as('x), 'c.as('y))
multiAlias.analyze.constraints
```
currently outputs:
```
ExpressionSet(Seq(
IsNotNull(resolveColumn(multiAlias.analyze, "x")),
IsNotNull(resolveColumn(multiAlias.analyze, "y"))
)
```
The constraint `resolveColumn(multiAlias.analyze, "x") === resolveColumn(multiAlias.analyze, "y") + 10)` is missing.
## How was this patch tested?
Add new test cases in `ConstraintPropagationSuite`.
Author: jiangxingbo <[email protected]>
Closes apache#15597 from jiangxb1987/alias-constraints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
UnaryNode.getAliasedConstraintsfunction fails to replace all expressions by their alias where constraints contains more than one expression to be replaced.For example:
currently outputs:
The constraint
resolveColumn(multiAlias.analyze, "x") === resolveColumn(multiAlias.analyze, "y") + 10)is missing.How was this patch tested?
Add new test cases in
ConstraintPropagationSuite.