Skip to content

Conversation

@manishatGit
Copy link

What changes were proposed in this pull request?

Added missing semicolon in quick-start-guide java example code which wasn't compiling before.

How was this patch tested?

Locally by running and generating site for docs. You can see the last line contains ";" in the below snapshot.
image

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's trivial, but it is needed to make the example compile. Could you look over other examples nearby in Java and see if you spot any other similar problems?

@srowen
Copy link
Member

srowen commented Nov 30, 2016

Jenkins test this please

@SparkQA
Copy link

SparkQA commented Nov 30, 2016

Test build #69407 has finished for PR 16081 at commit 6b01304.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@manishatGit
Copy link
Author

@srowen I scanned this page and Spark programming guide for other Java code examples, apart from Self-Contained Application on Quick-start-guide page, other code examples have no such problems.

@andrewor14
Copy link
Contributor

Ok, merging into master 2.1

asfgit pushed a commit that referenced this pull request Nov 30, 2016
## What changes were proposed in this pull request?

Added missing semicolon in quick-start-guide java example code which wasn't compiling before.

## How was this patch tested?
Locally by running and generating site for docs. You can see the last line contains ";" in the below snapshot.
![image](https://cloud.githubusercontent.com/assets/10628224/20751760/9a7e0402-b723-11e6-9aa8-3b6ca2d92ebf.png)

Author: manishAtGit <[email protected]>

Closes #16081 from manishatGit/fixed-quick-start-guide.

(cherry picked from commit bc95ea0)
Signed-off-by: Andrew Or <[email protected]>
@asfgit asfgit closed this in bc95ea0 Nov 30, 2016
asfgit pushed a commit that referenced this pull request Nov 30, 2016
## What changes were proposed in this pull request?

Added missing semicolon in quick-start-guide java example code which wasn't compiling before.

## How was this patch tested?
Locally by running and generating site for docs. You can see the last line contains ";" in the below snapshot.
![image](https://cloud.githubusercontent.com/assets/10628224/20751760/9a7e0402-b723-11e6-9aa8-3b6ca2d92ebf.png)

Author: manishAtGit <[email protected]>

Closes #16081 from manishatGit/fixed-quick-start-guide.
@andrewor14
Copy link
Contributor

and 2.0

robert3005 pushed a commit to palantir/spark that referenced this pull request Dec 2, 2016
## What changes were proposed in this pull request?

Added missing semicolon in quick-start-guide java example code which wasn't compiling before.

## How was this patch tested?
Locally by running and generating site for docs. You can see the last line contains ";" in the below snapshot.
![image](https://cloud.githubusercontent.com/assets/10628224/20751760/9a7e0402-b723-11e6-9aa8-3b6ca2d92ebf.png)

Author: manishAtGit <[email protected]>

Closes apache#16081 from manishatGit/fixed-quick-start-guide.
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
## What changes were proposed in this pull request?

Added missing semicolon in quick-start-guide java example code which wasn't compiling before.

## How was this patch tested?
Locally by running and generating site for docs. You can see the last line contains ";" in the below snapshot.
![image](https://cloud.githubusercontent.com/assets/10628224/20751760/9a7e0402-b723-11e6-9aa8-3b6ca2d92ebf.png)

Author: manishAtGit <[email protected]>

Closes apache#16081 from manishatGit/fixed-quick-start-guide.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants