[SPARK-19338][SQL] Add UDF names in explain #16707
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Maybe add a prefix so it is clear a UDF? e.g. |
Member
Author
|
Aha, SGTM. I'll fix |
|
Test build #72013 has started for PR 16707 at commit |
Contributor
|
LGTM pending jenkins. |
HyukjinKwon
reviewed
Jan 26, 2017
| val dataType = ScalaReflection.schemaFor[RT].dataType | ||
| val inputTypes = Try(Nil).toOption | ||
| def builder(e: Seq[Expression]) = ScalaUDF(func, dataType, e, inputTypes.getOrElse(Nil)) | ||
| def builder(e: Seq[Expression]) = ScalaUDF(func, dataType, e, inputTypes.getOrElse(Nil), Some(name)) |
Member
There was a problem hiding this comment.
Oh, I remember I was told that we should remove or fix the comments above to generate this codes too.
Member
Author
There was a problem hiding this comment.
oh, yea, you're right. Thanks! I'll fix
|
Test build #72010 has finished for PR 16707 at commit
|
Member
Author
|
It seems the latest test failure does not relate to this pr..., I'll test again. |
|
Test build #72014 has started for PR 16707 at commit |
Member
Author
|
Jenkins, retest this please. |
|
Test build #72018 has finished for PR 16707 at commit
|
Member
Author
|
@gatorsmile @rxin okay, it seems ready to merge. |
asfgit
pushed a commit
that referenced
this pull request
Jan 26, 2017
## What changes were proposed in this pull request? This pr added a variable for a UDF name in `ScalaUDF`. Then, if the variable filled, `DataFrame#explain` prints the name. ## How was this patch tested? Added a test in `UDFSuite`. Author: Takeshi YAMAMURO <[email protected]> Closes #16707 from maropu/SPARK-19338. (cherry picked from commit 9f523d3) Signed-off-by: gatorsmile <[email protected]>
Member
|
Thanks! Merging to master. |
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? This pr added a variable for a UDF name in `ScalaUDF`. Then, if the variable filled, `DataFrame#explain` prints the name. ## How was this patch tested? Added a test in `UDFSuite`. Author: Takeshi YAMAMURO <[email protected]> Closes apache#16707 from maropu/SPARK-19338.
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 15, 2017
## What changes were proposed in this pull request? This pr added a variable for a UDF name in `ScalaUDF`. Then, if the variable filled, `DataFrame#explain` prints the name. ## How was this patch tested? Added a test in `UDFSuite`. Author: Takeshi YAMAMURO <[email protected]> Closes apache#16707 from maropu/SPARK-19338.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr added a variable for a UDF name in
ScalaUDF.Then, if the variable filled,
DataFrame#explainprints the name.How was this patch tested?
Added a test in
UDFSuite.