[SPARK-19403][PYTHON][SQL] Correct pyspark.sql.column.__all__ list. #16742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #72153 has finished for PR 16742 at commit
|
|
LGTM |
|
LGTM, but can you update your description: Your current description actually means a different thing. |
This removes from the __all__ list class names that are not defined (visible) in the pyspark.sql.column.
|
@rxin Done. |
|
Merging in master. |
|
Thanks @rxin! |
|
Test build #72159 has finished for PR 16742 at commit
|
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 15, 2017
## What changes were proposed in this pull request? This removes from the `__all__` list class names that are not defined (visible) in the `pyspark.sql.column`. ## How was this patch tested? Existing unit tests. Author: zero323 <[email protected]> Closes apache#16742 from zero323/SPARK-19403.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This removes from the
__all__list class names that are not defined (visible) in thepyspark.sql.column.How was this patch tested?
Existing unit tests.